Re: RFR: 8245194: Unix domain socket channel implementation [v10]

2020-09-29 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

2020-09-29 Thread Kim Barrett
> On Sep 29, 2020, at 6:51 AM, Kim Barrett wrote: > >> On Sep 28, 2020, at 11:13 AM, Eric Liu wrote: >> >> Hi, >> >> Thanks for looking at this. >> >> For gcc-10, it's hard to make 'strncpy' all right with asan enabled >> (approaches we talked previous don't work). >> I'm trying to find a

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

2020-09-29 Thread Kim Barrett
> On Sep 28, 2020, at 11:13 AM, Eric Liu wrote: > > Hi, > > Thanks for looking at this. > > For gcc-10, it's hard to make 'strncpy' all right with asan enabled > (approaches we talked previous don't work). > I'm trying to find a better way to avoid using compile pragma. I suppose it > would

Re: RFR: 8245194: Unix domain socket channel implementation [v9]

2020-09-29 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use

Re: RFR: 8245194: Unix domain socket channel implementation [v8]

2020-09-29 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use

Re: RFR: 8245194: Unix domain socket channel implementation

2020-09-29 Thread Michael McMahon
On Fri, 11 Sep 2020 14:41:32 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more >> iterations before integrating. >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMahon w