Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

2020-09-28 Thread Eric Liu
Hi, Thanks for looking at this. For gcc-10, it's hard to make 'strncpy' all right with asan enabled (approaches we talked previous don't work). I'm trying to find a better way to avoid using compile pragma. I suppose it would be better to use 'memcpy' to replace 'strncpy'. Thanks, Eric

Integrated: 8253053: Javadoc clean up in Authenticator and BasicAuthenicator

2020-09-28 Thread Patrick Concannon
On Tue, 22 Sep 2020 15:13:27 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my doc-only fix for JDK-8253053 - 'Javadoc clean > up in Authenticator and BasicAuthenicator' > ? > This fix is set of formatting changes intended to clean up the javadoc of the > following classe

Re: RFR: 8253053: Javadoc clean up in Authenticator and BasicAuthenicator [v4]

2020-09-28 Thread Roger Riggs
On Mon, 28 Sep 2020 09:23:55 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8253053 - 'Javadoc clean >> up in Authenticator and BasicAuthenicator' >> ? >> This fix is set of formatting changes intended to clean up the javadoc of >> the following

Re: RFR: 8253053: Javadoc clean up in Authenticator and BasicAuthenicator [v4]

2020-09-28 Thread Michael McMahon
On Mon, 28 Sep 2020 09:23:55 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8253053 - 'Javadoc clean >> up in Authenticator and BasicAuthenicator' >> ? >> This fix is set of formatting changes intended to clean up the javadoc of >> the following

Re: RFR: 8253053: Javadoc clean up in Authenticator and BasicAuthenicator [v4]

2020-09-28 Thread Michael McMahon
On Mon, 28 Sep 2020 10:11:24 GMT, Michael McMahon wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now >> contains four commits: >> - 8253053: removed trailing >> - 8253053: fixed typo >> - 8253053: fixed typos; a

Re: RFR: 8253053: Javadoc clean up in Authenticator and BasicAuthenicator [v3]

2020-09-28 Thread Patrick Concannon
On Sat, 26 Sep 2020 07:04:48 GMT, Chris Hegarty wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental >> webrev excludes the unrelated changes brought in by the merge/rebase. The >> pull request contains three additional >

Re: RFR: 8253053: Javadoc clean up in Authenticator and BasicAuthenicator [v4]

2020-09-28 Thread Patrick Concannon
> Hi, > > Could someone please review my doc-only fix for JDK-8253053 - 'Javadoc clean > up in Authenticator and BasicAuthenicator' > ? > This fix is set of formatting changes intended to clean up the javadoc of the > following classes : > > `com.sun.net.httpserver.Authenticator` > `com.sun.net

Re: RFR: 8253053: Javadoc clean up in Authenticator and BasicAuthenicator [v4]

2020-09-28 Thread Daniel Fuchs
On Mon, 28 Sep 2020 08:56:14 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8253053 - 'Javadoc clean >> up in Authenticator and BasicAuthenicator' >> ? >> This fix is set of formatting changes intended to clean up the javadoc of >> the following