Hi Kim,
> Kim Barrett on Sent: 08 September 2020 20:28
>> On Sep 7, 2020, at 10:56 AM, Eric Liu wrote:
>> I have tested 4 cases for those warnings:
>> a) Without my patch, without asan, gcc-8 and gcc-10 are OK.
>> b) Without my patch, with asan, gcc-8 has warned, gcc-10 is OK.
>> c) With my
Hi Patrick,
Usually, the @param and @returns text does not edit a period (unless it
is a complete sentence).
The indentation of the new comment blocks is in a few places off.
I.e.
+++ b/src/jdk.httpserver/share/classes/com/sun/net/httpserver/Headers.java
Mon Aug 31 16:57:06 2020 +0100
@
On Tue, 8 Sep 2020 16:22:15 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint
> warnings in jdk.net.httpserver’ ?
>
> This fix addresses the warnings generated by `javadoc -Xdoclint` due to
> missing/incomplete API documentatio
Hi,
Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint
warnings in jdk.net.httpserver’ ?
This fix addresses the warnings generated by `javadoc -Xdoclint` due to
missing/incomplete API documentation for
several classes within `jdk.net.httpserver`.
Kind regards,
Patrick
On 08/09/2020 14:16, Daniel Fuchs wrote:
Hi Jaikiran,
I expect it's an incorrect use of the API. AFAICS JarURLConnection
has always behaved like this.
Opening an inputstream requires an entry, (see
https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/jar/JarFile.html#getInput
> On Sep 7, 2020, at 5:55 AM, Florian Weimer wrote:
>
> * Kim Barrett:
>
>> And strlen is not even necessarily the best solution, as it likely
>> introduces an additional otherwise unnecessary string traversal. For
>> example, getFlags could be changed to reject an overly long ifname,
>> without
> On Sep 7, 2020, at 10:56 AM, Eric Liu wrote:
> I have tested 4 cases for those warnings:
> a) Without my patch, without asan, gcc-8 and gcc-10 are OK.
> b) Without my patch, with asan, gcc-8 has warned, gcc-10 is OK.
> c) With my patch, without asan, gcc-8 and gcc-10 are OK.
That’s *very* stran
On Sun, 6 Sep 2020 05:46:42 GMT, Jaikiran Pai wrote:
> Can I please get a review and a sponsor for a fix for the issue reported at
> https://bugs.openjdk.java.net/browse/JDK-8252767?
> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty` is
> throwing a `IllegalAccessError`
