Re: RFR 8252248: __SIGRTMAX is not declared in musl libc

Looks good to me. Thanks for checking. Cheers, Thomas On Fri, Aug 28, 2020 at 1:25 PM Alexander Scherbatiy < alexander.scherba...@bell-sw.com> wrote: > Hello, > > Could you review the updated fix: >http://cr.openjdk.java.net/~alexsch/8252248/webrev.01/ > > - moving shared code to net_util_

Re: RFR 8252248: __SIGRTMAX is not declared in musl libc

+1 Vyom On Fri, Aug 28, 2020 at 8:24 PM Alexander Scherbatiy < alexander.scherba...@bell-sw.com> wrote: > On 28.08.2020 17:40, Alan Bateman wrote: > > > On 28/08/2020 15:32, Alexander Scherbatiy wrote: > >> > >> I run the java/nio/channels tests with the fix. There are five > >> failed tests th

Re: RFR 8252248: __SIGRTMAX is not declared in musl libc

On 28.08.2020 17:40, Alan Bateman wrote: On 28/08/2020 15:32, Alexander Scherbatiy wrote:   I run the java/nio/channels tests with the fix. There are five failed tests that fail with and without the fix:     java/nio/channels/DatagramChannel/AdaptorMulticasting.java java/nio/channels/Datagra

Re: RFR 8252248: __SIGRTMAX is not declared in musl libc

On 28/08/2020 15:32, Alexander Scherbatiy wrote:   I run the java/nio/channels tests with the fix. There are five failed tests that fail with and without the fix:     java/nio/channels/DatagramChannel/AdaptorMulticasting.java java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java    

Re: RFR 8252248: __SIGRTMAX is not declared in musl libc

On 28.08.2020 15:55, Alan Bateman wrote: On 28/08/2020 12:25, Alexander Scherbatiy wrote: Hello, Could you review the updated fix:   http://cr.openjdk.java.net/~alexsch/8252248/webrev.01/  - moving shared code to net_util_md.h is avoided  - INTERRUPT_SIGNAL is defined as SIGRTMAX - 2 instead

Re: RFR 8252248: __SIGRTMAX is not declared in musl libc

On 28/08/2020 12:25, Alexander Scherbatiy wrote: Hello, Could you review the updated fix:   http://cr.openjdk.java.net/~alexsch/8252248/webrev.01/  - moving shared code to net_util_md.h is avoided  - INTERRUPT_SIGNAL is defined as SIGRTMAX - 2 instead of __SIGRTMAX - 2 for Linux in NativeThrea

Re: RFR 8252248: __SIGRTMAX is not declared in musl libc

Hello, Could you review the updated fix:   http://cr.openjdk.java.net/~alexsch/8252248/webrev.01/  - moving shared code to net_util_md.h is avoided  - INTERRUPT_SIGNAL is defined as SIGRTMAX - 2 instead of __SIGRTMAX - 2 for Linux in NativeThread.c  - "#include " is moved out from "#ifdef" in

Re: 8245462: HttpClient send throws InterruptedException when interrupted but does not cancel request

On 28/08/2020 09:54, Daniel Fuchs wrote: Hi Michael, On 28/08/2020 09:46, Michael McMahon wrote: Daniel, I wonder if the new Cancelable interface could be simplified to remove the "mayInterruptIfRunning" parameter? It seems like the cancellation operation has no effect if the parameter is

Re: 8245462: HttpClient send throws InterruptedException when interrupted but does not cancel request

Hi Michael, On 28/08/2020 09:46, Michael McMahon wrote: Daniel, I wonder if the new Cancelable interface could be simplified to remove the "mayInterruptIfRunning" parameter? It seems like the cancellation operation has no effect if the parameter is false.. The interface mimics the Future::c

Re: 8245462: HttpClient send throws InterruptedException when interrupted but does not cancel request

Daniel, I wonder if the new Cancelable interface could be simplified to remove the "mayInterruptIfRunning" parameter? It seems like the cancellation operation has no effect if the parameter is false.. Otherwise, I am happy with the change. Thanks Michael On 31/07/2020 13:00, Michael McMaho