Re: Fix for Javadoc errors in java.base

2020-08-19 Thread Roger Riggs
Looks fine Julia On 8/18/20 1:02 PM, Julia Boes wrote: Hi, The two changes below still need to be reviewed. Any takers? Cheers, Julia --- old/src/java.base/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java2020-08-14 23:55:41.953638446 +0530 +++ new/src/java.base/sha

Re: RFR 8133686: REOPEN JDK-8080659 : HttpURLConnection?s getHeaderFields method returns field values in reverse order

2020-08-19 Thread Daniel Fuchs
Hi Evan, On 14/08/2020 13:10, Evan Whelan wrote: Hi all, I’m Evan and I’ve just recently joined the Java Platform Group here in Oracle so this is my first time getting to interact with the OpenJDK Community. This is a request to review my fix for https://bugs.openjdk.java.net/browse/JDK-81

Re: RFR 8250748: Doc of URL​(String, String, int, String, URLStreamHandler) does not use link

2020-08-19 Thread Daniel Fuchs
Hi Evan, Looks good to me! best regards, -- daniel On 19/08/2020 09:39, Evan Whelan wrote: Hi all, I have another small fix for net-dev reviewers. This is a small fix to the java/net/URL.java documentation to add a link to one of the constructors. --- old/open/src/java.base/share/classes

RFR 8250748: Doc of URL​(String, String, int, String, URLStreamHandler) does not use link

2020-08-19 Thread Evan Whelan
Hi all,   I have another small fix for net-dev reviewers. This is a small fix to the java/net/URL.java documentation to add a link to one of the constructors.   --- old/open/src/java.base/share/classes/java/net/URL.java   2020-08-18 14:53:33.886033182 + +++ new/open/src/java.base/share/