Hi,
Here is the new webrev that goes on top of the changes from
8229822 (which are already pushed).
http://cr.openjdk.java.net/~dfuchs/webrev_8245462/webrev.02/
I have also written the CSR:
https://bugs.openjdk.java.net/browse/JDK-8251312
feedback - and reviewers - welcome :-)
best regards,
Hi Pavel,
Thanks for the review!
On 07/08/2020 13:49, Pavel Rappo wrote:
May I suggest we use this?
ChannelState s;
assert (s = writeState.get()) == CLOSED : s;
Or better still,
ChannelState s = writeState.get();
assert s == CLOSED : s;
I'll do that before pushing.
be
Daniel,
The changes in TransportImpl look okay to me. I cannot see how they break
anything. On the other hand, I guess it will take some time to see if the
(complete) changeset fixes the issue.
One minor thing that makes me a tad bit uncomfortable is the new assert
statements. Firstly, they ma
Rahul,
> On 7 Aug 2020, at 10:09, Rahul Yadav wrote:
>
> Hello,
>
> ...
> Issue: https://bugs.openjdk.java.net/browse/JDK-8248006
> webrev: http://cr.openjdk.java.net/~ryadav/webrev_8248006/index.html
> csr : https://bugs.openjdk.java.net/browse/JDK-8251198
>
Looks good to me. I’m happy t
Daniel,
> On 31 Jul 2020, at 15:56, Daniel Fuchs wrote:
>
> Hi,
>
> Please find below a fix for:
>
> 8229822: ThrowingPushPromises tests sometimes fail due to EOF
> https://bugs.openjdk.java.net/browse/JDK-8229822
>
> While trying to write a good test for JDK-8245462 I stumbled
> on two issue
Hi Rahul,
Thanks for taking this on. This looks good to me.
Trivially, there is a space missing before "and" there:
362 * if the implementation requires a {@link Selector},and
opening
No need to publish a new webrev, just make sure to add the missing space
before pushing.
best reg
Thanks Chris!
best regards,
-- daniel
On 07/08/2020 09:44, Chris Hegarty wrote:
http://cr.openjdk.java.net/~dfuchs/webrev_8249786/webrev.02/
LGTM - extending repeatable to cover Windows platforms too.
( the previous problems with these tests came flooding back
when reading the comment in Pend
Hello,
Request to have my fix reviewed for issue:
JDK-8248006: Revisit exceptions thrown when creating an HttpClient
fails due to unavailability of underlying resources.
This fix updates jdk.internal.net.http.HttpClientImpl to throw an
UncheckedIOException instead of InternalError,
when cre
Daniel,
> On 23 Jul 2020, at 16:02, Daniel Fuchs wrote:
>
> Hi,
>
> More testing revealed that some other tests of the same family
> kept on failing intermittently, though my changes to
> PendingOperation.java should have fixed them.
>
> So here is a broader fix - which seems to have fixed th
