Re: RFR[8246164]: ‘SendDatagramToBadAddress.java and ChangingAddress.java should be changed to explicitly require the new DatagramSocket implementation’

2020-07-29 Thread Vyom Tiwari
Hi Patrick, Changes looks ok to me. Thanks, Vyom On Wed, Jul 29, 2020 at 9:45 PM Patrick Concannon < patrick.concan...@oracle.com> wrote: > Hi, > > Could someone please review my fix for JDK-8246164 — > ‘SendDatagramToBadAddress.java and ChangingAddress.java should be changed > to explicitly requ

RFR[8246164]: ‘SendDatagramToBadAddress.java and ChangingAddress.java should be changed to explicitly require the new DatagramSocket implementation’

2020-07-29 Thread Patrick Concannon
Hi, Could someone please review my fix for JDK-8246164 — ‘SendDatagramToBadAddress.java and ChangingAddress.java should be changed to explicitly require the new DatagramSocket implementation’. The issues addressed by the tests `java/net/DatagramSocket/SendDatagramToBadAddress.java` and `java/

Re: [java.net.http.HttpClient] Active monitoring of resolved IP addresses

2020-07-29 Thread Nicolas Henneaux
Hi Daniel, It is needed since the hostname sent in the HTTP client is the IP instead of the actual hostname to force the usage of a single IP. However, a specific SSLContext is used to ensure the hostname TLS validation is still done. Usage of the IP in the HTTP request

Re: [java.net.http.HttpClient] Active monitoring of resolved IP addresses

2020-07-29 Thread Daniel Fuchs
Hi Nicolas, On 29/07/2020 13:20, Nicolas Henneaux wrote: System.setProperty("jdk.internal.httpclient.disableHostnameVerification", Boolean.TRUE.toString()); System.setProperty("jdk.httpclient.allowRestrictedHeaders", "host"); I don't believe it's a good idea to disable/customize hostname veri

Re: [java.net.http.HttpClient] Active monitoring of resolved IP addresses

2020-07-29 Thread Nicolas Henneaux
Hi there, I haven't got news about this subject but I have built a library that works around the problem Github resilient-httpclient . It overrides the HTTP host header plus the SNI field in TLS handshake. It also provides custom TLS server name v