RE: RFR 15 8243099: SO_INCOMING_NAPI_ID support

2020-05-12 Thread Viswanathan, Sandhya
I have created the following draft CSR: https://bugs.openjdk.java.net/browse/JDK-8244858 Please review and let me know if I can move it to proposed. Best Regards, Sandhya -Original Message- From: net-dev On Behalf Of Alan Bateman Sent: Friday, May 08, 2020 12:10 AM To: Ivanov, Vladim

RFR 8244652: Add test for non utf-8 response handling by websocket client

2020-05-12 Thread Rahul
  Hello, Request to have my fix reviewed for the issue: JDK-8244652: Add test for non utf-8 response handling by websocket client. The test java.net.httpclient.websocket.WSHandshakeExceptionTest.java is updated to test   that the websocket client handles invalid utf-8 sent b

Re: RFR: 8244853 - The static build of libextnet is missing the JNI_OnLoad_extnet function

2020-05-12 Thread Alan Bateman
Looks okay to me. On 12/05/2020 19:46, Bob Vandette wrote: BUG: https://bugs.openjdk.java.net/browse/JDK-8244853 Please review this simple fix for JDK 15 which adds the required JNI_OnLoad_extnet function to the libextnet.a static library when it is built. the JDK 15 make static-libs-image t

Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support

2020-05-12 Thread Vyom Tiwari
Thanks for the clarification Alan. I think, i missed some part of discussion. Vyom On Tue, May 12, 2020 at 1:20 PM Alan Bateman wrote: > On 12/05/2020 08:34, Vyom Tiwari wrote: > > Hi Vladimir, > > Latest changes looks good to me, but i am not 100% sure if we need to > distinguish between "read

Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support

2020-05-12 Thread Alan Bateman
On 12/05/2020 08:34, Vyom Tiwari wrote: Hi Vladimir, Latest changes looks good to me, but i am not 100% sure if we need to distinguish between "read only socket option" and "socket option not supported" as below if (!incomingNapiIdOptSupported) + throw new UnsupportedOperationException("Atte

Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support

2020-05-12 Thread Vyom Tiwari
Hi Vladimir, Latest changes looks good to me, but i am not 100% sure if we need to distinguish between "read only socket option" and "socket option not supported" as below if (!incomingNapiIdOptSupported)+throw new UnsupportedOperationException("Attempt to set unsupported