Hi Alan,
Yeah, sounds good. I’ve added that test case as requested, and you can
find it in the updated webrev below.
http://cr.openjdk.java.net/~pconcannon/8243488/webrevs/webrev.01/
Kind regards,
Patrick
On 24/04/2020 09:59, Alan Bateman wrote:
On 23/04/2020 16:46, Patrick Concannon wrot
> On 24 Apr 2020, at 16:14, Daniel Fuchs wrote:
>
> Hi Chris,
>
> On 23/04/2020 19:36, Chris Hegarty wrote:
>> How do you feel about adding a byte-at-a-time final scenario?
>> static final List REQ5_RESPONSE_BODY = List.of(
>> "B", " ", "\r", "\n",
>> "L", "o", "r", "e", "m", "
Hi Chris,
On 23/04/2020 19:36, Chris Hegarty wrote:
How do you feel about adding a byte-at-a-time final scenario?
static final List REQ5_RESPONSE_BODY = List.of(
"B", " ", "\r", "\n",
"L", "o", "r", "e", "m", " ", "i", "p", "s", "u", "m", "\r" ,"\n",
"0", ";", " ", "\
Hello,
Request to have my fix reviewed for the issue:
JDK-8242999 : http/2 client may not handle continuation frames correctly.
The fix updates jdk.internal.net.http.Stream.incoming(Http2Frame frame) to
handle
the scenario where a continuation with `END_HEADERS` may appear aft
On 23/04/2020 16:46, Patrick Concannon wrote:
Hi,
Could someone please review my fix for JDK-8243488 'Add tests for
set/get SendBufferSize and getReceiveBufferSize in DatagramSocket'?
This fix adds tests for the methods: setSendBufferSize(int),
getSendBufferSize(), and getReceieveBufferSize(
> On 23 Apr 2020, at 16:46, Patrick Concannon
> wrote:
>
> Hi,
>
> Could someone please review my fix for JDK-8243488 'Add tests for set/get
> SendBufferSize and getReceiveBufferSize in DatagramSocket'?
>
> This fix adds tests for the methods: setSendBufferSize(int),
> getSendBufferSize(),
Hi Alan,
On 24/04/2020 07:09, Alan Bateman wrote:
It looks like there are >3000 lines of embedded data, is a reason why
these responses can't be loaded from data files? Some of these could be
text blocks too of course but they are really long and might be better
as data files.
I originally h
Hi Vladimir,
In LinuxSocketOptions.c we have lot's of duplicate code, can you please
reuse "socketOptionSupported" & "handleError" as follows, this we remove
lot's of duplicate code.
Thanks,
Vyom
diff -r b6b4506a7827 src/jdk.net/linux/native/libextnet/LinuxSocketOptions.c
--- a/src/jdk.net/linux/
On 23/04/2020 20:11, Ivanov, Vladimir A wrote:
Thanks a lot to Chris and Alan for detailed comments.
The updated version of patch available at
http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.01/
Changes:
1. in native code the common pattern was used for the 'getsockopt' call.
2
