8238270: java.net HTTP/2 client does not decrease stream count when receives 204 response

2020-04-14 Thread Daniel Fuchs
Hi, Please find below a fix for: 8238270: java.net HTTP/2 client does not decrease stream count when receives 204 response https://bugs.openjdk.java.net/browse/JDK-8238270 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8238270/webrev.00/index.html For convenience reason, the Http2C

Re: 8241995: Clarify InetSocketAddress::toString specification

2020-04-14 Thread Daniel Fuchs
On 14/04/2020 15:00, Michael McMahon wrote: Hi Chris,     possible wording for your last paragraph: To retrieve a string representation of the hostname, or in the absence of a hostname, the string form of the address, use {@link #getHostString()}, rather than parsing the toString string represen

Re: 8241995: Clarify InetSocketAddress::toString specification

2020-04-14 Thread Michael McMahon
On 03/04/2020 21:39, mark sheppard wrote: Hi Chris,     possible wording for your last paragraph: To retrieve a string representation of the hostname, or in the absence of a hostname, the string form of the address, use {@link #getHostString()}, rather than parsing the toString string represent

Re: RFR[8241072]: 'Reimplement Legacy DatagramSocket API'

2020-04-14 Thread Alan Bateman
On 14/04/2020 10:20, Daniel Fuchs wrote: That's where I disagree because it's a slight difference in behavior between the old implementation and the new - so I believe it's worth having a test for it (even if does test the presence of a bug in the old impl). I like this test because it does s

Re: RFR[8241072]: 'Reimplement Legacy DatagramSocket API'

2020-04-14 Thread Daniel Fuchs
Hi Alan, On 12/04/2020 16:51, Alan Bateman wrote: I don't think SetGetSendBufferSize should be in the webrev. It has @bug 8239355 so it's for a different issue. Patrick will confirm but IIRC this test was added because coverage testing reported that DS::setSendBufferSize was never called (pres