Re: RFR [15] 8242044: Add basic HTTP/1.1 support to the HTTP/2 Test Server

+1 Michael On 02/04/2020 15:39, Daniel Fuchs wrote: Looks good to me Chris. best regards, -- daniel On 02/04/2020 15:11, Chris Hegarty wrote: To more easily write HTTP Client test scenarios for different protocol versions and different TLS versions, it would be very convenient if the HTTP/2

Re: RFR [15] 8242044: Add basic HTTP/1.1 support to the HTTP/2 Test Server

Looks good to me Chris. best regards, -- daniel On 02/04/2020 15:11, Chris Hegarty wrote: To more easily write HTTP Client test scenarios for different protocol versions and different TLS versions, it would be very convenient if the HTTP/2 server, that is part of the JDK regression test suite,

RFR [15] 8242044: Add basic HTTP/1.1 support to the HTTP/2 Test Server

To more easily write HTTP Client test scenarios for different protocol versions and different TLS versions, it would be very convenient if the HTTP/2 server, that is part of the JDK regression test suite, was able to issue basic HTTP/1.1 responses. This enhance adds minimal support, which effectiv

Re: Java 14 - Change in InetSocketAddress.toString() behaviour seems to be causing issues

Thank you Chris. -Jaikiran On 01/04/20 6:40 pm, Chris Hegarty wrote: > > >> On 1 Apr 2020, at 13:48, Jaikiran Pai > > wrote: > ... Now that you explained it to me, I see what you mean and what that javadoc means. I hadn't paid attention to the "

Re: 8241786: 3 DatagramChannel tests and 2 MulticastSocket tests fail due to "SocketException: No buffer space available"

Hi Chris, On 02/04/2020 09:40, Chris Hegarty wrote: This is a functional change that affects the product build. Maybe that would be a little clearer from a different bug synopsis. Suggest something like: Improve heuristic to determine default network interface on macOS I can do that - or I

Re: 8241786: 3 DatagramChannel tests and 2 MulticastSocket tests fail due to "SocketException: No buffer space available"

On 02/04/2020 09:48, Daniel Fuchs wrote: : DefaultInterface might be better in a test infra class (in java/net) to avoid duplicate it in several tests. I have considered that. The problem is that it requires the test that uses it to add @modules java.base/java.net:+open directive in the te

Re: 8241786: 3 DatagramChannel tests and 2 MulticastSocket tests fail due to "SocketException: No buffer space available"

Hi Alan, On 01/04/2020 20:50, Alan Bateman wrote: The change to java.net.DefaultInterface to workaround bad configurations on macOS looks good. Hopefully existing usages of the 1-arg joinGroup will migrate to the 2-arg variant and avoid needing the JDK to choose on multi-homed systems. Thank

Re: 8241786: 3 DatagramChannel tests and 2 MulticastSocket tests fail due to "SocketException: No buffer space available"

Daniel, > On 1 Apr 2020, at 18:42, Daniel Fuchs wrote: > > Hi, > > Please find below a fix for: > > 8241786: 3 DatagramChannel tests and 2 MulticastSocket tests > fail due to "SocketException: No buffer space available" > https://bugs.openjdk.java.net/browse/JDK-8241786 Good work. A r