Re: 8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration

2020-03-26 Thread Daniel Fuchs
Hi Alan. On 26/03/2020 17:29, Alan Bateman wrote: NetworkConfiguration.isTestable - is the hardcoded check for "awdl" needed? I don't think I've seen it with non-link local address so I can't tell if it is needed. I'm It might no longer be needed, but we know that awdl is always the wrong cho

Re: 8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration

2020-03-26 Thread Alan Bateman
On 26/03/2020 15:36, Daniel Fuchs wrote: Hi, Please find below a fix for: 8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration https://bugs.openjdk.java.net/browse/JDK-8241336 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_82413

Re: RFR JDK-8239595/JDK-8239594 : ssl context version is not respected/jdk.tls.client.protocols is not respected

2020-03-26 Thread Xuelei Fan
With this update, the logic looks like: if TLSv1.3 is not enabled in the SSLContext, use TLSv1.2 instead; Otherwise, use TLSv1.3 and TLSv1.2. There may be a couple of issues: 1. TLSv1.2 may be not enabled, although TLSv1.3 is enabled. For example: System.setProperty("jdk.tls.client.protocols

Re: RFR JDK-8239595/JDK-8239594 : ssl context version is not respected/jdk.tls.client.protocols is not respected

2020-03-26 Thread Sean Mullan
I think you should mark one of the two bugs a duplicate. Typically I mark the more recent one as a duplicate, unless there is a good reason to do otherwise. --Sean On 3/26/20 12:28 PM, Sean Mullan wrote: Cross-posting to security-dev as this involves TLS/SSL configuration. --Sean On 3/26/20

Re: RFR JDK-8239595/JDK-8239594 : ssl context version is not respected/jdk.tls.client.protocols is not respected

2020-03-26 Thread Sean Mullan
Cross-posting to security-dev as this involves TLS/SSL configuration. --Sean On 3/26/20 10:02 AM, rahul.r.ya...@oracle.com wrote: Hello, Request to have my fix reviewed for issues:     JDK-8239595 : ssl context version is not respected     JDK-8239594 : jdk.tls.client.protocols is not respe

8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration

2020-03-26 Thread Daniel Fuchs
Hi, Please find below a fix for: 8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration https://bugs.openjdk.java.net/browse/JDK-8241336 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8241336/webrev.01/index.html The crux of the i

Re: 8241674 (XS): Fix incorrect jtreg option in FilePublisherPermsTest

2020-03-26 Thread Chris Hegarty
LGTM. -Chris > On 26 Mar 2020, at 14:32, Julia Boes wrote: > > Hi, > > Could someone please review this small fix of a recently pushed test? The > option to extend the policy file has to be 'java.security.policy' instead of > 'policy' - this was discussed on this mailing list but then mira

Re: 8241674 (XS): Fix incorrect jtreg option in FilePublisherPermsTest

2020-03-26 Thread Daniel Fuchs
Thanks for jumping on this Julia! Reviewed. Since this is making some noise in the CI I suggest to push it asap. best regards, -- daniel On 26/03/2020 14:32, Julia Boes wrote: Hi, Could someone please review this small fix of a recently pushed test? The option to extend the policy file has

8241674 (XS): Fix incorrect jtreg option in FilePublisherPermsTest

2020-03-26 Thread Julia Boes
Hi, Could someone please review this small fix of a recently pushed test? The option to extend the policy file has to be 'java.security.policy' instead of 'policy' -  this was discussed on this mailing list but then miraculously ignored by myself... Bug: https://bugs.openjdk.java.net/browse/

RFR JDK-8239595/JDK-8239594 : ssl context version is not respected/jdk.tls.client.protocols is not respected

2020-03-26 Thread rahul . r . yadav
Hello, Request to have my fix reviewed for issues:     JDK-8239595 : ssl context version is not respected     JDK-8239594 : jdk.tls.client.protocols is not respected The fix updates jdk.internal.net.http.HttpClientImpl.getDefaultParams(SSLContext ctx) to use ctx.getDefaultSSLParameters()instea