Hi Daniel/Michael,
Please find the latest webrev(
http://cr.openjdk.java.net/~vtewari/8237858/webrev0.2/index.html), where i
put a test case as well.
Thanks,
Vyom
On Wed, Mar 11, 2020 at 3:16 PM Bernd Eckenfels
wrote:
> Hello,
>
> Depending on the test environment you don't need much native too
I updated the CSR and local code.
Thanks,
Xuelei
On 3/16/2020 10:23 AM, Alan Bateman wrote:
On 16/03/2020 16:00, Xuelei Fan wrote:
Hi Alan,
Thanks for the review. All comments look good to me. Here is the
update webrev:
http://cr.openjdk.java.net/~xuelei/8241039/webrev.01/
HandshakeC
On 16/03/2020 16:00, Xuelei Fan wrote:
Hi Alan,
Thanks for the review. All comments look good to me. Here is the
update webrev:
http://cr.openjdk.java.net/~xuelei/8241039/webrev.01/
HandshakeCompletedEvent.java and SSLSession.java are updated.
Thanks. One suggestion is to use "The def
On 3/16/2020 3:37 AM, Daniel Fuchs wrote:
Hi Xuelei,
HandshakeCompletedEvent.java: typo:
186 "This method has retired, pleaase use the " +
Same in SSLSession.java:
303 "This method has retired, pleaase use the " +
I removed the sections per Alan's comment.
Hi Alan,
Thanks for the review. All comments look good to me. Here is the
update webrev:
http://cr.openjdk.java.net/~xuelei/8241039/webrev.01/
HandshakeCompletedEvent.java and SSLSession.java are updated.
Thanks,
Xuelei
On 3/16/2020 12:36 AM, Alan Bateman wrote:
On 16/03/2020 04:25, Xue
Hi Alex,
(and redirecting the thread to net-dev)
It looks like a straight forward solution and perhaps the compatibility test
could be challenged on the basis of reliance on implementation behavior
rather than the spec.
But, more important I think is the behavior change of the fix itself and
Hi Xuelei,
HandshakeCompletedEvent.java: typo:
186 "This method has retired, pleaase use the " +
Same in SSLSession.java:
303 "This method has retired, pleaase use the " +
WRT to the HttpClient code I wonder whether the deprecated method
should be kept. On the on
On 16/03/2020 04:25, Xuelei Fan wrote:
Hi,
Could I get the following update reviewed?
Bug: https://bugs.openjdk.java.net/browse/JDK-8241039
CSR: https://bugs.openjdk.java.net/browse/JDK-8241047
webrev: http://cr.openjdk.java.net/~xuelei/8241039/webrev.00/
I see you've created a new issue (and
