LGTM.
-Chris
> On 13 Feb 2020, at 23:06, sha.ji...@oracle.com wrote:
>
> Hi,
> java/net/httpclient/HandshakeFailureTest.java should be in the problem list
> until JDK-8238990 is resolved.
>
> diff -r 87651cb03ebc test/jdk/ProblemList.txt
> --- a/test/jdk/ProblemList.txtThu Feb 13 13:43:09
Hi All,
Please find the below fix which resolves the issue(
https://bugs.openjdk.java.net/browse/JDK-8238579).
"HttpURLConnection.writeRequests()" retry in case of any write failure,
during retry it creates new HttpsClient without connectTimeout &
readTimeout. Below fix sets the connect & read
Hi,
java/net/httpclient/HandshakeFailureTest.java should be in the problem
list until JDK-8238990 is resolved.
diff -r 87651cb03ebc test/jdk/ProblemList.txt
--- a/test/jdk/ProblemList.txt Thu Feb 13 13:43:09 2020 -0800
+++ b/test/jdk/ProblemList.txt Fri Feb 14 07:05:39 2020 +0800
@@ -627,
> On 13 Feb 2020, at 14:27, Patrick Concannon
> wrote:
>
> Hi,
>
>
> Could someone please review my webrev for JDK-8234812 'Add micros for
> DatagramChannel send/receive' ?
>
> This test adds some benchmarks for the DatagramChannel's send, receive, read
> and write methods.
>
>
> bug:
Hi Daniel/Vyom,
As mentioned in the review comments ,
Change in test case HttpURLConWithProxy.java is to make sure we don’t throw
an error “Can’t use direct connection” even when the connection is made through
proxy. i.e to make sure the existing test case won't fail because of the fix.
Danie
Thanks Vyom.
I was suspecting as much.
Ravi, could you come up with a test that fails without the fix
and pass with it?
best regards,
-- daniel
On 13/02/2020 14:26, Vyom Tiwari wrote:
Hi Ravi/Daniel,
At my local env(REL 7) test is passing without fix as well. Although my
local repo contai
Hi,
Could someone please review my webrev for JDK-8234812 'Add micros for
DatagramChannel send/receive' ?
This test adds some benchmarks for the DatagramChannel's send, receive,
read and write methods.
bug: https://bugs.openjdk.java.net/browse/JDK-8234812
webrev: http://cr.openjdk.java.ne
Hi Ravi/Daniel,
At my local env(REL 7) test is passing without fix as well. Although my
local repo contain some additional code changes but it is not related with
the current fix.
Test1 Passed with: Connect timed out
Test2 Passed with: Connect timed out
##
Please
Hi,
On 13/02/2020 10:52, Ravi Reddy wrote:
I notice that the `break` from the original code has not been
reintroduced. I don't think that it is strictly needed, but did you give
it any consideration?
Chris , in original code since we were doing retry with direct
connection and not proceeding
Hi Claes,
Thanks for the feedback.
I've reduced the parameters to 5 i.e. "128", "512", "2048", "8192", "32768"
I've also removed the main method to conform with the layout of the other
benchmark tests.
You can find the changes in the updated webrev below:
http://cr.openjdk.java.net/~pconcann
Hi John,
This looks good to me. Thanks for taking care of that and
for logging JDK-8238990!
best regards,
-- daniel
On 13/02/2020 05:23, sha.ji...@oracle.com wrote:
Hi,
java/net/httpclient/HandshakeFailureTest.java should cover TLSv1.3 as well.
java/net/httpclient/ShortResponseBody.java would
Hi Chris,
From: Chris Hegarty
Sent: Thursday, February 13, 2020 3:07 PM
To: Ravi Reddy
Cc: net-dev@openjdk.java.net
Subject: Re: RFR[15] JDK-8183369 : RFC unconformity of HttpURLConnection with
proxy
Hi Ravi,
On 5 Feb 2020, at 12:43, Ravi Reddy mailto:ravi.k.re...@oracle.com"ravi.k.
Hi Ravi,
> On 5 Feb 2020, at 12:43, Ravi Reddy wrote:
>
> Hello All,
>
> Could you please review this patch. This patch fixes the RFC unconformity of
> HttpURLConnection with proxy issue.
>
> 1.Change in HttpURLConnection.java is to make sure we do retry with proxy as
> mentioned in RFC
>
13 matches
Mail list logo
