RFR[15] JDK-8234718: java/net/httpclient tests should cover TLSv1.3

2020-02-12 Thread sha . jiang
Hi, java/net/httpclient/HandshakeFailureTest.java should cover TLSv1.3 as well. java/net/httpclient/ShortResponseBody.java would not specify a TLS protocol. Please note the value of the system property jdk.internal.httpclient.debug in HandshakeFailureTest.java is changed to false due to JDK-823

Re: RFR[8237480]: Add micros for DatagramSocket send/receive

2020-02-12 Thread Claes Redestad
Hi, looks reasonable to me. To keep default execution times at a manageable level, I'd recommend excluding some of the 9 values for the size parameter (3-5 values seem reasonable). /Claes On 2020-02-12 16:04, Patrick Concannon wrote: Hi, Could someone please review my webrev for JDK-8237480

RFR[8237480]: Add micros for DatagramSocket send/receive

2020-02-12 Thread Patrick Concannon
Hi, Could someone please review my webrev for JDK-8237480 'Add micros for DatagramSocket send/receive' ? This change adds some benchmarks for the DatagramSocket::send and DatagramSocket::receive methods. bug: https://bugs.openjdk.java.net/browse/JDK-8237480 webrev: http://cr.openjdk.java