Re: RFR[15] 8238677: java/net/httpclient/ssltest/CertificateTest.java should not specify TLS version

Hi Daniel, Would it be possible to include a comment in Cert.java that contains the command you used to generate the certificates? That will be a great help to future maintainers if the certificates ever needs to be re-generated (e.g. to update the expiry date etc...) I'll do that. Please re

Re: RFR: JDK-8238386: (sctp) jdk.sctp/unix/native/libsctp/SctpNet.c "multiple definition" link errors with GCC10

> On 7 Feb 2020, at 14:08, Patrick Zhang OS > wrote: > > Agree, I was wondering where to place them, SctpNet.c or SctpChannelImpl.c. > Here is the update: http://cr.openjdk.java.net/~qpzhang/8238386/webrev.02/ > (smoke tested the build only) > And, thanks for your double-check with the modif

RE: RFR: JDK-8238386: (sctp) jdk.sctp/unix/native/libsctp/SctpNet.c "multiple definition" link errors with GCC10

Agree, I was wondering where to place them, SctpNet.c or SctpChannelImpl.c. Here is the update: http://cr.openjdk.java.net/~qpzhang/8238386/webrev.02/ (smoke tested the build only) And, thanks for your double-check with the modified Lib-jdk.sctp.gmk. :) Regards Patrick -Original Message

Re: RFR[15] 8238677: java/net/httpclient/ssltest/CertificateTest.java should not specify TLS version

Hi Daniel, On 2020/2/7 19:29, Daniel Fuchs wrote: Hi John, Looks good to me. Thanks for taking care of this! I'm glad to see the binary files go away :-) Thanks for your review! Would it be possible to include a comment in Cert.java that contains the command you used to generate the certifi

Re: RFR: JDK-8238386: (sctp) jdk.sctp/unix/native/libsctp/SctpNet.c "multiple definition" link errors with GCC10

Patrick, > On 7 Feb 2020, at 08:44, Patrick Zhang OS > wrote: > > Ping.. Pong ;-) > Regards > Patrick > > -Original Message- > From: net-dev On Behalf Of Patrick Zhang OS > Sent: Wednesday, February 5, 2020 8:19 PM > To: Chris Hegarty ; net-dev > > Subject: RE: RFR: JDK-8238386: (

Re: RFR[15] 8238677: java/net/httpclient/ssltest/CertificateTest.java should not specify TLS version

Hi John, Looks good to me. Thanks for taking care of this! I'm glad to see the binary files go away :-) Would it be possible to include a comment in Cert.java that contains the command you used to generate the certificates? That will be a great help to future maintainers if the certificates eve

RFR[15] 8238677: java/net/httpclient/ssltest/CertificateTest.java should not specify TLS version

Hi, java/net/httpclient/ssltest/CertificateTest.java shouldn't use a specific TLS version. And it would be better not to use binary key store files. Since DSA is not supported by TLSv1.3, this fix also updates the certificates to use RSA. Webrev: http://cr.openjdk.java.net/~jjiang/8238677/web

RE: RFR: JDK-8238386: (sctp) jdk.sctp/unix/native/libsctp/SctpNet.c "multiple definition" link errors with GCC10

Ping.. Regards Patrick -Original Message- From: net-dev On Behalf Of Patrick Zhang OS Sent: Wednesday, February 5, 2020 8:19 PM To: Chris Hegarty ; net-dev Subject: RE: RFR: JDK-8238386: (sctp) jdk.sctp/unix/native/libsctp/SctpNet.c "multiple definition" link errors with GCC10 Thanks