Re: [PATCH] 7006496: Use modern Windows API to retrieve OS DNS servers

2020-01-07 Thread Anuraag Agrawal
Hi Chris, Happy new year - sorry for the long delay. I have made an updated patch fixing the comment (missing comma), bumping MAX_STR_LEN, and tweaking the exception behavior. Basically, as you pointed out loadDNSConfig itself does not throw any exception. The getAdapters function will throw a) O

Re: Reading from a closed socket: different behavior between Linux and other operating systems

2020-01-07 Thread Simone Bordet
Hi, On Mon, Jan 6, 2020 at 5:39 PM Chris Hegarty wrote: > // force RST > clientChannel.setOption(StandardSocketOptions.SO_LINGER, 0); Just want to point out that when the channel/socket is set in non-blocking mode, SO_LINGER is either not supported or gives undefined behavior or throws (

Re: Reading from a closed socket: different behavior between Linux and other operating systems

2020-01-07 Thread Dawid Weiss
Thank you for your feedback. I can understand how this behavior can be considered platform-dependent but it's still a bit surprising that it shows consistent behavior on everything except Linux... (we originally thought it's Windows to be blamed here). For the SSL layer I implemented a workaround