Re: RFR [14] 8236441: Bound MulticastSocket fails when setting outbound interface on Windows

2019-12-21 Thread Chris Hegarty
> On 21 Dec 2019, at 08:23, Alan Bateman wrote: > > On 20/12/2019 22:34, Chris Hegarty wrote: >> >> Thanks Alan, >> >> 1) I updated the file descriptor check from ` > 0` to ` >= 0` >> 2) Removed the pre-existing incorrect comment, and >> 3) Added a few more test scenarios that check the index

Re: RFR [14] 8236441: Bound MulticastSocket fails when setting outbound interface on Windows

2019-12-21 Thread Alan Bateman
On 20/12/2019 22:34, Chris Hegarty wrote: Thanks Alan, 1) I updated the file descriptor check from ` > 0` to ` >= 0` 2) Removed the pre-existing incorrect comment, and 3) Added a few more test scenarios that check the index = 0 cases Updated webrev: https://cr.openjdk.java.net/~chegar/8236441/