Re: Anyone maintaining or know of a custom DatagramSocketImpl ?

2019-12-18 Thread Alan Bateman
On 18/12/2019 16:47, Chris Hegarty wrote: : Specifically on this point, the two-arg variants of `joinGroup` and `leaveGroup` throw an UnsupportedOperationException if invoked on a MulticastSocket that has a DatagramSocketImpl which was compiled against a pre-1.4 version of the DSI interface. ( th

Re: Anyone maintaining or know of a custom DatagramSocketImpl ?

2019-12-18 Thread Chris Hegarty
> On 18 Dec 2019, at 13:14, Alan Bateman wrote: > > > … because MulticastSocket can't work with a DatagramSocketImpl that hasn't > been upgraded. Specifically on this point, the two-arg variants of `joinGroup` and `leaveGroup` throw an UnsupportedOperationException if invoked on a Multicast

Re: RFR[8235783]: DatagramSocket::disconnect should allow an implementation to throw UncheckedIOException

2019-12-18 Thread Daniel Fuchs
On 18/12/2019 16:06, Chris Hegarty wrote: Not withstanding the various different post-close behaviour of the methods of DatagramSocket ( throw IOException, silently ignore, return a default value, return last known value ), I think that it would be best to clarify the specification with the exist

Re: RFR[8235783]: DatagramSocket::disconnect should allow an implementation to throw UncheckedIOException

2019-12-18 Thread Chris Hegarty
> On 18 Dec 2019, at 11:09, Alan Bateman wrote: > > On 18/12/2019 10:55, Daniel Fuchs wrote: >> We already have two implementations of DatagramSocket: one is the plain >> DatagramSocket, the other is the DatagramSocket adapter created by >> DatagramChannel::socket. >> >> Even without preparin

Anyone maintaining or know of a custom DatagramSocketImpl ?

2019-12-18 Thread Alan Bateman
DatagramSocket and MulticastSocket delegate to a DatagramSocketImpl, a provider-like mechanism that dates from early JDK releases. I'm wondering if anyone is aware of any implementations and whether they are still maintained. The context for asking is whether anyone would notice if the JDK d

Re: RFR[8235783]: DatagramSocket::disconnect should allow an implementation to throw UncheckedIOException

2019-12-18 Thread Alan Bateman
On 18/12/2019 10:55, Daniel Fuchs wrote: We already have two implementations of DatagramSocket: one is the plain DatagramSocket, the other is the DatagramSocket adapter created by DatagramChannel::socket. Even without preparing for DatagramSocket reimplementation this is a step forward in homoge

Re: RFR[8235783]: DatagramSocket::disconnect should allow an implementation to throw UncheckedIOException

2019-12-18 Thread Daniel Fuchs
Hi Alan, On 18/12/2019 11:01, Alan Bateman wrote: I guess my point here is that UncheckedIOException will never be thrown, which might be okay if the primary motive is to prepare DatagramSocket for the new implementation. We already have two implementations of DatagramSocket: one is the plain

Re: RFR[8235783]: DatagramSocket::disconnect should allow an implementation to throw UncheckedIOException

2019-12-18 Thread Alan Bateman
On 17/12/2019 14:35, Patrick Concannon wrote: Hi, Could someone please review my fix and CSR for issue JDK-8235783 'DatagramSocket::disconnect should allow an implementation to throw UncheckedIOException'? DatagramChannel's connect and disconnect methods throw an IOException while DatagramS