RE: RFR: JDK-8235903: GCC default -fno-common exposes "multiple definition" link errors

Thanks Martin. Hi net-dev, and/or security-dev Reviewers, Please help review and sponsor this patch if acceptable. It does not tend to bring any functionality changes, instead to propose an early fix, for the build (linking) errors with further toolchain (GCC 10). JBS: https://bugs.openjdk.java

Re: RFR [15] 5064980: URI compareTo inconsistent with equals for mixed-case escape sequences

Hi Kiran, 1844 if (result == 0) 1845 return true; 1846 else 1847 return false; could maybe be simplified into: return result == 0; 1925 if (s.indexOf('%') < 0) { 1926 return s.compareTo(t); 1927 }

Re: RFR [14] 8235976: Directives in WWW-Authenticate should be comma separated

> On 16 Dec 2019, at 15:48, Michael McMahon > wrote: > > Could I get the following small fix reviewed please? > > It is a followup to 8199849 which is already in 14. > The fix did not include the required comma separator between parameters > in HTTP response authentication headers. > > http

Re: RFR [15] 5064980: URI compareTo inconsistent with equals for mixed-case escape sequences

> On 16 Dec 2019, at 15:54, Kiran Ravikumar > wrote: > > Thanks Daniel and Chris, > > Here is my updated webrev with the mentioned corrections. > > http://cr.openjdk.java.net/~kravikumar/5064980/webrev.01/ > LGTM. -Chris.

Re: RFR [15] 5064980: URI compareTo inconsistent with equals for mixed-case escape sequences

Thanks Daniel and Chris, Here is my updated webrev with the mentioned corrections. http://cr.openjdk.java.net/~kravikumar/5064980/webrev.01/ Please review at your convenience. Thanks, Kiran On 16/12/2019 14:04, Chris Hegarty wrote: Kiran, On 13 Dec 2019, at 18:28, Kiran Ravikumar

RFR [14] 8235976: Directives in WWW-Authenticate should be comma separated

Could I get the following small fix reviewed please? It is a followup to 8199849 which is already in 14. The fix did not include the required comma separator between parameters in HTTP response authentication headers. http://cr.openjdk.java.net/~michaelm/8235976/webrev.1/ Thanks, Michael.

Re: RFR [15] 5064980: URI compareTo inconsistent with equals for mixed-case escape sequences

Kiran, > On 13 Dec 2019, at 18:28, Kiran Ravikumar > wrote: > > Hi Guys, > > > > Could someone please review my fix to URI.java class were URI.compareTo(URI) > behavior was different to URI.equals(URI). URI.compareTo(URI) does not > consider two URI's to be equal when they differ only in t

Re: (test-only) RFR: 8235925: java/net/Socket/HttpProxy.java fails on IPv4 only hosts and other small cleanups

Daniel, > On 13 Dec 2019, at 18:53, Daniel Fuchs wrote: > > Hi, > > Please find below a fix for: > > 8235925: java/net/Socket/HttpProxy.java fails on IPv4 only hosts > and other small cleanups > https://bugs.openjdk.java.net/browse/JDK-8235925 > > webrev: > http://cr.openjdk.java.net/

Re: JDK 14 issue in BasicAuthenticator

I'll fix this. Thanks for reporting and filing the bug. - Michael. On 16/12/2019 08:17, Alan Bateman wrote: On 15/12/2019 16:52, Simone Bordet wrote: Hi, the Jetty integration with HttpServerProvider is failing a couple of tests in JDK 14 (they pass in earlier JDKs). This is due to the fact

Re: JDK 14 issue in BasicAuthenticator

On 15/12/2019 16:52, Simone Bordet wrote: Hi, the Jetty integration with HttpServerProvider is failing a couple of tests in JDK 14 (they pass in earlier JDKs). This is due to the fact that com.sun.net.httpserver.BasicAuthenticator has been changed to report the charset in the WWW-Authenticate h