Re: RFR: 8231516: network QuickAckTest.java failed due to "SocketException: maximum number of DatagramSockets reached"

2019-11-28 Thread Alan Bateman
On 22/11/2019 16:35, Chris Hegarty wrote: : QuickAckTest only creates one DatagramSocket and one MulticastSocket, so just consumes two UDP socket resources. Prior tests run in the same VM must be consuming the majority of UDP socket resources ( and not releasing them), then this test just happens

Re: RFR[8233307]: MulticastSocket getOption(IP_MULTICAST_IF) returns interface when not set

2019-11-28 Thread Daniel Fuchs
Looks good to me Patrick! Thanks for the test updates :-) best regards, -- daniel On 28/11/2019 13:01, Patrick Concannon wrote: Hi Chris, Thanks for your feedback. I've incorporated your comments into the fix, and the changes can be found in the updated webrev below. webrev: http://cr.op

Re: RFR[8233307]: MulticastSocket getOption(IP_MULTICAST_IF) returns interface when not set

2019-11-28 Thread Chris Hegarty
> On 28 Nov 2019, at 13:01, Patrick Concannon > wrote: > > Hi Chris, > > Thanks for your feedback. > > I've incorporated your comments into the fix, and the changes can be found in > the updated webrev below. > > webrev: http://cr.openjdk.java.net/~pconcannon/8233307/webrevs/webrev.02/ L

Re: RFR[8233307]: MulticastSocket getOption(IP_MULTICAST_IF) returns interface when not set

2019-11-28 Thread Patrick Concannon
Hi Chris, Thanks for your feedback. I've incorporated your comments into the fix, and the changes can be found in the updated webrev below. webrev: http://cr.openjdk.java.net/~pconcannon/8233307/webrevs/webrev.02/ Kind regards, Patrick On 28/11/2019 09:36, Chris Hegarty wrote: Patrick,

Re: RFR[8233307]: MulticastSocket getOption(IP_MULTICAST_IF) returns interface when not set

2019-11-28 Thread Chris Hegarty
Patrick, > On 27 Nov 2019, at 14:54, Patrick Concannon > wrote: > > Hi, > > > Could someone please review my fix and CSR for issue JDK-8233307 > 'MulticastSocket getOption(IP_MULTICAST_IF) returns interface when not set'? > > The IP_MULTICAST_IF socket option is specified to have an initial