Re: RFR: 8231516: network QuickAckTest.java failed due to "SocketException: maximum number of DatagramSockets reached"

2019-11-22 Thread Chris Hegarty
> On 22 Nov 2019, at 15:09, Daniel Fuchs wrote: > > Hi, > > Please find below a trivial fix for: > 8231516: network QuickAckTest.java failed due to > "SocketException: maximum number of DatagramSockets reached" > https://bugs.openjdk.java.net/browse/JDK-8231516 > > The test should be

Re: RFR: 8234629: remove unused functions from libnet

2019-11-22 Thread Alan Bateman
On 22/11/2019 13:29, Baesken, Matthias wrote: Hello, The linktime section-gc   ( see also https://mail.openjdk.java.net/pipermail/build-dev/2019-November/026326.html   ) found a couple of other potentially unused functions / variables in libnet . This change removes  the found  functio

RFR: 8231516: network QuickAckTest.java failed due to "SocketException: maximum number of DatagramSockets reached"

2019-11-22 Thread Daniel Fuchs
Hi, Please find below a trivial fix for: 8231516: network QuickAckTest.java failed due to "SocketException: maximum number of DatagramSockets reached" https://bugs.openjdk.java.net/browse/JDK-8231516 The test should be run in /othervm mode to avoid being impacted by other tests that mig

RFR: 8234629: remove unused functions from libnet

2019-11-22 Thread Baesken, Matthias
Hello, The linktime section-gc ( see also https://mail.openjdk.java.net/pipermail/build-dev/2019-November/026326.html ) found a couple of other potentially unused functions / variables in libnet . This change removes the found functions / variables. Bug/webrev : https://bugs.openjdk.jav

Re: RFR: 8233296: MulticastSocket getOption/setOption inverts the value of IP_MULTICAST_LOOP

2019-11-22 Thread Daniel Fuchs
Thanks Alan! On 21/11/2019 21:15, Alan Bateman wrote: I think I would cast to boolean rather than Boolean (because it's boolean on the LHS) to make it a bit clearer. The rest looks good. OK - I'll do that before pushing. Although for me, given an Object obj, it's actually more natural to do: