Re: RFR [14] 8232367: Update the jdk/java/net/httpclient tests to RS TCK 1.0.3

2019-11-01 Thread Pavel Rappo
Chris, Which commit is this update based on? I think this is worth mentioning for the future maintainers. We supplied this information when we made the initial push: https://mail.openjdk.java.net/pipermail/net-dev/2019-June/012810.html -Pavel > On 1 Nov 2019, at 17:11, Chris Hegarty wrote

Re: [teststabilization] RFR: 8233403: Improve verbosity of some httpclient tests

2019-11-01 Thread Chris Hegarty
> On 1 Nov 2019, at 17:57, Daniel Fuchs wrote: > > Hi, > > Please find below a change to some HttpClient tests that should > improve diagnosability if they fail: > > 8233403: Improve verbosity of some httpclient tests > https://bugs.openjdk.java.net/browse/JDK-8233403 > > webrev: > http://c

[teststabilization] RFR: 8233403: Improve verbosity of some httpclient tests

2019-11-01 Thread Daniel Fuchs
Hi, Please find below a change to some HttpClient tests that should improve diagnosability if they fail: 8233403: Improve verbosity of some httpclient tests https://bugs.openjdk.java.net/browse/JDK-8233403 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8233403/webrev.00/ best regards, -- d

Re: RFR [14] 8232367: Update the jdk/java/net/httpclient tests to RS TCK 1.0.3

2019-11-01 Thread Daniel Fuchs
Looks good to me Chris. best regards, -- daniel On 01/11/2019 17:11, Chris Hegarty wrote: The RS TCK tests added by 8226602 are based on version 1.0.2. There is a newer version 1.0.3 available. In what is in the test area of the JDK repo, there are only trivial minor stability changes betwe

RFR [14] 8232367: Update the jdk/java/net/httpclient tests to RS TCK 1.0.3

2019-11-01 Thread Chris Hegarty
The RS TCK tests added by 8226602 are based on version 1.0.2. There is a newer version 1.0.3 available. In what is in the test area of the JDK repo, there are only trivial minor stability changes between 1.0.2 and 1.0.3, but seems worth pulling in, if only to not have to continually remember/mo

Re: RFR: 8232853: AuthenticationFilter.Cache::remove may throw ConcurrentModificationException

2019-11-01 Thread Daniel Fuchs
Thanks for this fix Julia! WRT to the test, I'd suggest this to make it more maintainable: static final int REQUEST_COUNT = 5; static final int URI_COUNT = 6; 67 static final CyclicBarrier barrier = new CyclicBarrier(REQUEST_COUNT * URI_COUNT); 257 vo

RFR: 8232853: AuthenticationFilter.Cache::remove may throw ConcurrentModificationException

2019-11-01 Thread Julia Boes
Hi, This fix addresses an issue in AuthenticationFilter.Cache::remove that can lead to a ConcurrentModificationException. The cache is implemented as LinkedList, the method iterates over the list and potentially removes items without using an iterator. To reproduce the bug, multiple requests