Re: [teststabilization] RFR: 8231631: sun/net/ftp/FtpURLConnectionLeak.java fails intermittently with NPE

2019-10-23 Thread Vyom Tiwari
Hi Daniel, Code change looks good to me. Thanks, Vyom On Wed, Oct 23, 2019 at 10:50 PM Daniel Fuchs wrote: > Hi, > > Please find below a trivial test fix for: > > 8231631: sun/net/ftp/FtpURLConnectionLeak.java fails intermittently > with NPE > https://bugs.openjdk.java.net/browse/JDK

[teststabilization] RFR: 8231631: sun/net/ftp/FtpURLConnectionLeak.java fails intermittently with NPE

2019-10-23 Thread Daniel Fuchs
Hi, Please find below a trivial test fix for: 8231631: sun/net/ftp/FtpURLConnectionLeak.java fails intermittently with NPE https://bugs.openjdk.java.net/browse/JDK-8231631 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8231631/webrev.00/ readLine() returns null on EOF - which was m

Re: RFR[8231570]: (dc) Clarify implicit bind behavior of DatagramChannel

2019-10-23 Thread Daniel Fuchs
Hi Patrick, That looks good to me too. I can sponsor it for you after you generate a proper hg-importable changeset. best regards, -- daniel On 16/10/2019 19:20, Patrick Concannon wrote: [Resending with nio-dev in cc] Hi, Could someone please review my fix and CSR for issue JDK-8231570 '(d