Re: RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma

Hi Ivan, On 10/1/19 10:26 PM, Ivan Gerasimov wrote: Hello! The constructors of SocketPermission and FilePermission expect a String argument with comma-separated list of actions. If the list is malformed, then the constructors throw IllegalArgumentException. It turns out that the current i

Re: RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma

Thank you Joe for checking it! On 10/2/19 4:38 PM, Joe Darcy wrote: Hello, At least from a quick reading, either the spec change or the behavior change would seem to merit a CSR. Sigh.  I was hopping it'll be a quick fix :-) So, I filed CSR: https://bugs.openjdk.java.net/browse/JDK-8231805

Re: RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma

Hello, At least from a quick reading, either the spec change or the behavior change would seem to merit a CSR. Cheers, -Joe On 10/2/2019 4:26 PM, Ivan Gerasimov wrote: Hi Chris! Thank you very much for review! I agree that it makes sense to update the javadoc for consistency. I don't thi

Re: RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma

Hi Chris! Thank you very much for review! I agree that it makes sense to update the javadoc for consistency. I don't think CSR is required in this case, is it? (IAE is unchecked anyway, and the fix doesn't really change the behavior.) Here's the updated webrev: http://cr.openjdk.java.net/~i

RFR: 8231449: HttpClient’s client ssl certificate authentication seems to be broken.

Hi, Please find below a fix for: 8231449: HttpClient’s client ssl certificate authentication seems to be broken. https://bugs.openjdk.java.net/browse/JDK-8231449 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8231449/webrev.00/ The root of the issue is that the HttpClient's SSLFlow

Re: RFR[8222829]: DatagramSocket.setSoTimeout does not specify IAE when timeout is negative

Hi, I've updated the webrev following feedback received here, and from the CSR on this issue. webrev: http://cr.openjdk.java.net/~pconcannon/8222829/webrevs/webrev.02/ CSR: https://bugs.openjdk.java.net/browse/JDK-8231401 Kind regards, Patrick On 26/09/2019 14:47, Daniel Fuchs wrote: On

Re: RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma

Ivan, On 01/10/2019 21:26, Ivan Gerasimov wrote: Hello! The constructors of SocketPermission and FilePermission expect a String argument with comma-separated list of actions. If the list is malformed, then the constructors throw IllegalArgumentException. It turns out that the current impl

Re: RFR[8230946]: Clarify security manager behaviour of a connected DatagramSocket and DatagramChannel

On 02/10/2019 11:16, Patrick Concannon wrote: Hi Daniel, Well spotted. I've fixed that now, and updated the webrev. Looks good.

Re: RFR[8230946]: Clarify security manager behaviour of a connected DatagramSocket and DatagramChannel

Hi Daniel, Well spotted. I've fixed that now, and updated the webrev. Kind regards, Patrick On 02/10/2019 11:05, Daniel Fuchs wrote: Hi Patrick: DatagramSocket.java: typo 712  * If there is a security manager, and th esocket is not currently Otherwise looks good to me too! best re

Re: RFR[8230946]: Clarify security manager behaviour of a connected DatagramSocket and DatagramChannel

Hi Patrick: DatagramSocket.java: typo 712 * If there is a security manager, and th esocket is not currently Otherwise looks good to me too! best regards, -- daniel On 02/10/2019 10:49, Patrick Concannon wrote: Hi, I've updated the fix for JDK-8230946

Re: RFR[8230946]: Clarify security manager behaviour of a connected DatagramSocket and DatagramChannel

> On 2 Oct 2019, at 10:49, Patrick Concannon > wrote: > Hi, > > I've updated the fix for JDK-8230946 with the feedback received here and from > the CSR (JDK-8231305). The new webrev can be found below: > http://cr.openjdk.java.net/~pconcannon/8230946/webrevs/webrev.04/ > Thanks Patrick. Loo

Re: RFR[8230946]: Clarify security manager behaviour of a connected DatagramSocket and DatagramChannel

Hi, I've updated the fix for JDK-8230946 with the feedback received here and from the CSR (JDK-8231305 ). The new webrev can be found below: http://cr.openjdk.java.net/~pconcannon/8230946/web