Re: RFR[8222829]: DatagramSocket.setSoTimeout does not specify IAE when timeout is negative

2019-09-27 Thread Alan Bateman
On 27/09/2019 16:00, Patrick Concannon wrote: Hi Alan, I've added a similar check for DatagramChannel socket adaptor as requested. You can find it in the webrev below. http://cr.openjdk.java.net/~pconcannon/8219446/webrevs/webrev.01/ Thanks, look good (just a minor nit that you've lost a

Re: RFR[8230946]: Clarify security manager behaviour of a connected DatagramSocket and DatagramChannel

2019-09-27 Thread Alan Bateman
On 27/09/2019 16:07, Patrick Concannon wrote: Hi Alan, Thanks for the review. On 24/09/2019 16:25, Alan Bateman wrote: The clarification to DatagramSocket.receive on how it behaves when there is a security manager and not connected may require some adjusting to DatagramChannel's receive

Re: RFR[8230946]: Clarify security manager behaviour of a connected DatagramSocket and DatagramChannel

2019-09-27 Thread Patrick Concannon
Hi Alan, Thanks for the review. On 24/09/2019 16:25, Alan Bateman wrote: The clarification to DatagramSocket.receive on how it behaves when there is a security manager and not connected may require some adjusting to DatagramChannel's receive spec too. The specification is that a SecurityEx

Re: RFR[8222829]: DatagramSocket.setSoTimeout does not specify IAE when timeout is negative

2019-09-27 Thread Patrick Concannon
Hi Alan, I've added a similar check for DatagramChannel socket adaptor as requested. You can find it in the webrev below. http://cr.openjdk.java.net/~pconcannon/8219446/webrevs/webrev.01/ Kind regards, Patrick On 26/09/2019 14:38, Alan Bateman wrote: On 26/09/2019 14:26, Patrick Concanno

Re: RFR (XS) 8230415 : Avoid redundant permission checking in FilePermissionCollection and SocketPermissionCollection

2019-09-27 Thread Sean Mullan
Hi Ivan, The fix looks good. Good catch. --Sean On 8/30/19 7:32 PM, Ivan Gerasimov wrote: Hello! In the two implementations of PermissionCollection.implies(Permission), all the permissions are traversed, and their corresponding bit mask are checked. For example, here's a snippet from File