Re: RFR[8217825]: Verify @AfterTest is used correctly in WebSocket tests

2019-09-23 Thread Patrick Concannon
Hi Pavel, Thanks for the feedback. I've incorporated the changes you suggested, and you can find them in the new webrev below. http://cr.openjdk.java.net/~pconcannon/8217825/webrevs/webrev.02/ Kind regards, Patrick On 20/09/2019 13:21, Pavel Rappo wrote: Patrick, Thank you for taking care o

Re: Unix domain sockets (UDS, AF_UNIX) in System.inheritedChannel() and elsewhere in Java + [JDK-8231187] + [JDK-8231358]

2019-09-23 Thread Michael McMahon
Hi Franta, I have filed https://bugs.openjdk.java.net/browse/JDK-8231358 to cover the general case of support for UNIX domain sockets. I think we should fix this bug independent of that though. The test case you supplied incl. native launcher was useful for this. So, thanks for that. The change

Re: Unix domain sockets (UDS, AF_UNIX) in System.inheritedChannel() and elsewhere in Java + [JDK-8231187] + [JDK-8231358]

2019-09-23 Thread František Kučera
In response to: and > Best to ask František to argue his approach on nio-dev. The concern with his approach is that it converts the local/remote address to an IPv4 address, makes it looks like