Re: RFR[8217825]: Verify @AfterTest is used correctly in WebSocket tests

2019-09-20 Thread Pavel Rappo
Patrick, Thank you for taking care of that! Before you push, please add missing spaces to WebSocketTest.java:612 WebSocketTest.java:713 (no need to update the webrev) Nits: WebSocketTest.java:808 does not abort WebSocket. Now, I understand that in normal circumstances we never expect

Re: RFR[8217825]: Verify @AfterTest is used correctly in WebSocket tests

2019-09-20 Thread Daniel Fuchs
Hi Patrick, Looks good to me! best regards, -- daniel On 20/09/2019 11:27, Patrick Concannon wrote: Hi Daniel, Thanks for the feedback. That's a good idea. I've made those changes and I've included them in the webrev below. http://cr.openjdk.java.net/~pconcannon/8217825/webrevs/webrev.01

Re: RFR[8217825]: Verify @AfterTest is used correctly in WebSocket tests

2019-09-20 Thread Patrick Concannon
Hi Daniel, Thanks for the feedback. That's a good idea. I've made those changes and I've included them in the webrev below. http://cr.openjdk.java.net/~pconcannon/8217825/webrevs/webrev.01/ Kind regards, Patrick On 13/09/2019 15:47, Daniel Fuchs wrote: Hi Patrick, I wonder if you should