Hello Daniel,
On 30/08/19 9:14 PM, Daniel Fuchs wrote:
> Hi Jaikiran,
>
> 1075 System.out.println("Server will stop
> accepting connections due to an exception");
> 1076 io.printStackTrace(System.out);
> 1077 break;
>
> Two things here:
>
Hello!
In the two implementations of PermissionCollection.implies(Permission),
all the permissions are traversed, and their corresponding bit mask are
checked.
For example, here's a snippet from FilePermission.java:
int desired = fperm.getMask();
int effective = 0;
in
Hi Jaikiran,
1075 System.out.println("Server will stop accepting
connections due to an exception");
1076 io.printStackTrace(System.out);
1077 break;
Two things here:
1.if ss.connect() throws, it may be because ss is closed, or not.
Looks fine to me.
- Michael.
On 29/08/2019, 18:04, Julia Boes wrote:
Hi,
This fix involves a test that failed during thread cleanup. To address
this, the ServerSocket is now being closed at the end and the server
thread is joined. While at it, I removed some unnecessary whitespace.
webrev:
Looks fine to me.
- Michael.
On 29/08/2019, 16:01, Patrick Concannon wrote:
Hi,
Would it be possible to have my fix for JDK-8230132 reviewed?
java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java was
failing intermittently on Windows due to random addresses being
returned from the
On 30/08/19 5:40 PM, Jaikiran Pai wrote:
> Can I please get a review and a sponsor for a patch for
> https://bugs.openjdk.java.net/browse/JDK-8223714?
>
> The patch is available as a webrev at
> http://cr.openjdk.java.net/~jpai/webrev/8223714/1/webrev/
>
> This issue and the patch relates solely
Can I please get a review and a sponsor for a patch for
https://bugs.openjdk.java.net/browse/JDK-8223714?
The patch is available as a webrev at
http://cr.openjdk.java.net/~jpai/webrev/8223714/1/webrev/
This issue and the patch relates solely to a test infrastructure class -
HTTPTestServer and tou
Hello Chris, Alan & all.
Thank you for your discussions with František and thanks for outlining various
directions to move his inquiry forward.
> You will need to find a sponsor
Right. I feel motivated to help, as I talked František into contributing
rather than hacking around the problems he
