Hi Matthias,
looks good to me, too. And +1 for dropping the comment.
Best regards
Christoph
> -Original Message-
> From: net-dev On Behalf Of Chris
> Hegarty
> Sent: Freitag, 16. August 2019 13:44
> To: Baesken, Matthias
> Cc: net-dev@openjdk.java.net
> Subject: Re: RFR [XS] : 8229706:
Looks good to me Julia!
I will push your changes.
best regards,
-- daniel
On 26/08/2019 12:09, Julia Boes wrote:
Thanks for catching that, Aleksei!
Updated webrev:
http://cr.openjdk.java.net/~dfuchs/jboes/823/webrev.02/index.html
Cheers,
Julia
On 23/08/2019 18:52, Daniel Fuchs wrot
Thank you Michael for reviewing and sponsoring.
-Jaikiran
On 26/08/19 5:02 PM, Michael McMahon wrote:
> Jaikiran,
>
> The CSR was approved, and the change has been pushed.
> Thanks for the contribution.
>
> Michael.
>
> On 22/08/2019, 17:19, Jaikiran Pai wrote:
>>
>>
>> On 22/08/19 8:17 PM, Micha
Hi Mark,
On 24/08/2019 12:33, mark sheppard wrote:
a couple of observations on the assertion for test failure that you may
wish to consider.
If there is a BindException for the DatagramSocket instantiations
then this would suggest that there is an operating system issue.
The sockets are be
Jaikiran,
The CSR was approved, and the change has been pushed.
Thanks for the contribution.
Michael.
On 22/08/2019, 17:19, Jaikiran Pai wrote:
On 22/08/19 8:17 PM, Michael McMahon wrote:
Getting back to this issue. I have filed a CSR at
https://bugs.openjdk.java.net/browse/JDK-8230044
Th
Can I please get a review and a sponsor for the patch for
https://bugs.openjdk.java.net/browse/JDK-8177389. The patch is available
as a webrev at http://cr.openjdk.java.net/~jpai/webrev/8177389/1/webrev/.
The change that's asked for, in that JBS, is actually trivial. While I
was at it, I also chan
Thanks for catching that, Aleksei!
Updated webrev:
http://cr.openjdk.java.net/~dfuchs/jboes/823/webrev.02/index.html
Cheers,
Julia
On 23/08/2019 18:52, Daniel Fuchs wrote:
Oh! Good catch Aleksei!
In fact all three files are missing the comma.
cheers,
-- daniel
On 23/08/2019 18:47, A
