Re: [teststabilization] RFR 8229348: java/net/DatagramSocket/UnreferencedDatagramSockets.java fails intermittently

2019-08-09 Thread Chris Hegarty
> On 9 Aug 2019, at 16:36, Daniel Fuchs wrote: > > Hi, > > Please find below a trivial fix for: > > 8229348: java/net/DatagramSocket/UnreferencedDatagramSockets.java > fails intermittently > https://bugs.openjdk.java.net/browse/JDK-8229348 > > webrev: http://cr.openjdk.java.net/~dfuc

Re: RFR [8203036]: com.sun.net.httpserver.HttpExchange should implement AutoCloseable

2019-08-09 Thread Daniel Fuchs
Hi, This looks good to me Patrick. best regards, -- daniel On 09/08/2019 12:09, Patrick Concannon wrote: Hi, Would it be possible to have my fix, and corresponding CSR, for JDK-8203036 reviewed? This fix addresses the retrofitting of HttpExchange to implement AutoCloseable so that it ca

[teststabilization] RFR 8229348: java/net/DatagramSocket/UnreferencedDatagramSockets.java fails intermittently

2019-08-09 Thread Daniel Fuchs
Hi, Please find below a trivial fix for: 8229348: java/net/DatagramSocket/UnreferencedDatagramSockets.java fails intermittently https://bugs.openjdk.java.net/browse/JDK-8229348 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8229348/webrev.00/ This test has been observed failing int

Re: RFR: 8185898: setRequestProperty(key, null) results in HTTP header without colon in request

2019-08-09 Thread Chris Hegarty
Julia, > On 9 Aug 2019, at 13:40, Julia Boes wrote: > > Hi, > > Please find an alternative fix below. Chris and Daniel suggested to add a new > method MessageHeader::isRequestline rather than a separate data field for the > requestline. A whitebox test was added with the method testMessageHea

Re: RFR: 8185898: setRequestProperty(key, null) results in HTTP header without colon in request

2019-08-09 Thread Daniel Fuchs
Hi Julia, On 09/08/2019 13:40, Julia Boes wrote: Hi, Please find an alternative fix below. Chris and Daniel suggested to add a new method MessageHeader::isRequestline rather than a separate data field for the requestline. A whitebox test was added with the method testMessageHeader. Updated

Re: RFR: 8185898: setRequestProperty(key, null) results in HTTP header without colon in request

2019-08-09 Thread Julia Boes
Hi, Please find an alternative fix below. Chris and Daniel suggested to add a new method MessageHeader::isRequestline rather than a separate data field for the requestline. A whitebox test was added with the method testMessageHeader. Updated webrev: http://cr.openjdk.java.net/~michaelm/jboes

RFR [8203036]: com.sun.net.httpserver.HttpExchange should implement AutoCloseable

2019-08-09 Thread Patrick Concannon
Hi, Would it be possible to have my fix, and corresponding CSR, for JDK-8203036 reviewed? This fix addresses the retrofitting of HttpExchange to implement AutoCloseable so that it can be used with try-with-resources statements. The CSR for the fix can be found here: https://bugs.openjdk.j