Re: RFR: 8227721: NetworkInterfaceRetrievalTests.java should open the java.net package

2019-07-18 Thread Alan Bateman
On 18/07/2019 15:43, Patrick Concannon wrote: Oh OK, I didn't realise. Thanks for pointing this out, Alan! I've removed the 'othervm' tag, and added it to the new webrev below. http://cr.openjdk.java.net/~aefimov/pconcann/8227721/01/ This looks good to me. -Alan

Re: RFR: 8227721: NetworkInterfaceRetrievalTests.java should open the java.net package

2019-07-18 Thread Patrick Concannon
Oh OK, I didn't realise. Thanks for pointing this out, Alan! I've removed the 'othervm' tag, and added it to the new webrev below. http://cr.openjdk.java.net/~aefimov/pconcann/8227721/01/ Kind regards, Patrick On 18/07/2019 08:53, Alan Bateman wrote: On 17/07/2019 17:52, Patrick Concannon wr

Re: RFR: 8227721: NetworkInterfaceRetrievalTests.java should open the java.net package

2019-07-18 Thread Alan Bateman
On 17/07/2019 17:52, Patrick Concannon wrote: : This fix sets the test to run in 'othervm' mode, and gives 'open' access to 'java.net' to the unnamed module (where the test lives). I don't think you need to run the test in /othervm mode as jtreg will look after spinning up a new agent VM whe