Re: RFR: 8227587: Add internal privileged System.loadLibrary

2019-07-16 Thread Mandy Chung
On 7/16/19 6:48 AM, Claes Redestad wrote: Hi, refactored to use a BootLoader::loadLibrary API that is only visible within the java.base module: http://cr.openjdk.java.net/~redestad/8227587/open.03/ Looks good. Nit:  in JavaLangAccess    321 void loadLibrary(Class klass, String librar

Re: RFR: 8227720: Improve ExtendedSocketOptions initialization

2019-07-16 Thread Claes Redestad
On 2019-07-16 17:11, Vyom Tewari26 wrote: Looks good to me. Vyom Thanks for reviewing, Vyom /Claes

Re: RFR: 8227720: Improve ExtendedSocketOptions initialization

2019-07-16 Thread Vyom Tewari26
Looks good to me. Vyom   - Original message -From: Claes Redestad Sent by: "net-dev" To: OpenJDK Network Dev list Cc:Subject: [EXTERNAL] RFR: 8227720: Improve ExtendedSocketOptions initializationDate: Tue, Jul 16, 2019 7:36 PM  Hi,a small cleanup and startup optimization for apps that setup

RFR : 8227737: avoid implicit-function-declaration on AIX

2019-07-16 Thread Baesken, Matthias
Hello, please review the following AIX related change . It fixes a number of missing inclusions leading to implicit-function-declaration warnings when compiling with the recent xlc16 /xlclang . At various places in the native C coding in jdk, we miss header inclusions on AIX. This leads

Re: RFR: 8227720: Improve ExtendedSocketOptions initialization

2019-07-16 Thread Claes Redestad
On 2019-07-16 17:01, Chris Hegarty wrote: On 16 Jul 2019, at 15:06, Claes Redestad wrote: Webrev: http://cr.openjdk.java.net/~redestad/8227720/open.00/ This looks good to me Claes. Thanks for doing it. Reviewed. Thanks for reviewing, Chris! /Claes

Re: RFR: 8227720: Improve ExtendedSocketOptions initialization

2019-07-16 Thread Chris Hegarty
Claes, > On 16 Jul 2019, at 15:06, Claes Redestad wrote: > > Hi, > > a small cleanup and startup optimization for apps that setup and/or use > sockets of various kinds, which pulls in ExtendedSocketOptions. By being > slightly more eager we avoid a few potentially costly streams (featuring > ca

Re: RFR: 8227587: Add internal privileged System.loadLibrary

2019-07-16 Thread Chris Hegarty
> On 16 Jul 2019, at 14:48, Claes Redestad wrote: > > Hi, > > refactored to use a BootLoader::loadLibrary API that is only visible > within the java.base module: > > http://cr.openjdk.java.net/~redestad/8227587/open.03/ I think that this is good Claes. Reviewed. -Chris.

RFR: 8227720: Improve ExtendedSocketOptions initialization

2019-07-16 Thread Claes Redestad
Hi, a small cleanup and startup optimization for apps that setup and/or use sockets of various kinds, which pulls in ExtendedSocketOptions. By being slightly more eager we avoid a few potentially costly streams (featuring capturing lambdas) that we'd end up calling eagerly from places like Abstra

Re: RFR: 8227587: Add internal privileged System.loadLibrary

2019-07-16 Thread Claes Redestad
Hi, refactored to use a BootLoader::loadLibrary API that is only visible within the java.base module: http://cr.openjdk.java.net/~redestad/8227587/open.03/ I've retained the bridge to ClassLoader::loadLibrary for performance, but without any magic or privilege escalation involved. Moving sys_pa