Patrick,
> On 25 Jun 2019, at 15:36, Patrick wrote:
>
> Hi,
>
> Would it be possible to have my fix for JDK-8226730 reviewed?
>
> Fix inserts missing '@' symbols in code tags.
>
> Webrev for fix: http://cr.openjdk.java.net/~aefimov/pconcann/8226730/00/
Looks good, thanks Patrick.
-Chris.
Thanks for the review Brian. I will help Patrick to push the change
Best Regards,
Aleksei
On 25/06/2019 15:57, Patrick wrote:
Ok, thanks Brian.
Will change before pushing.
On 6/25/19 3:51 PM, Brian Burkhalter wrote:
Hi Patrick,
Looks OK to me except the 2017 copyright year in URLStreamHandl
Ok, thanks Brian.
Will change before pushing.
On 6/25/19 3:51 PM, Brian Burkhalter wrote:
Hi Patrick,
Looks OK to me except the 2017 copyright year in URLStreamHandler needs to be
2019.
Thanks,
Brian
On Jun 25, 2019, at 7:36 AM, Patrick wrote:
Hi,
Would it be possible to have my fix fo
Hi Patrick,
Looks OK to me except the 2017 copyright year in URLStreamHandler needs to be
2019.
Thanks,
Brian
> On Jun 25, 2019, at 7:36 AM, Patrick wrote:
>
> Hi,
>
> Would it be possible to have my fix for JDK-8226730 reviewed?
>
> Fix inserts missing '@' symbols in code tags.
>
> Webre
Hi,
Would it be possible to have my fix for JDK-8226730 reviewed?
Fix inserts missing '@' symbols in code tags.
Webrev for fix: http://cr.openjdk.java.net/~aefimov/pconcann/8226730/00/
Kind regards,
Patrick
Hi Pavel,
This looks very good! Thanks for driving this effort.
Would it be possible to add a one-line comment at the beginning
of each test to explain what they are testing?
For instance, I see in BodyPublishersFromPublisher.java:
32 /* See TckDriver.java for more information */
33 public
Pavel,
> On 24 Jun 2019, at 13:31, Pavel Rappo wrote:
>
> Hello,
>
> Please review the following change:
>
>http://cr.openjdk.java.net/~prappo/8226602/webrev.00/
Thanks for doing this Pavel, the changes look great.
> This change adds reactive streams conformance testing of convenience
>
On 25/06/2019, 07:37, Alan Bateman wrote:
On 24/06/2019 21:57, Rob Spoor wrote:
I found a bug in Inet6Adress.isIPv4CompatibleAddress(). While parsing
correctly uses the ::: format, isIPv4CompatibleAddress()
checks for :: instead.
The notion "IPv4-compatible IPv6 address" is different to "IP
