Pushed, thanks for the reviews.
On Thu, Jun 6, 2019 at 4:23 AM Chris Hegarty
wrote:
> +1 from me too.
>
> Arthur,
>
> This test is failing quite frequently in our build and test system. If not
> pushed by this time tomorrow, I will push it on your behalf.
>
> -Chris.
>
> > On 6 Jun 2019, at 12:1
On 06/06/2019 16:25, Chris Hegarty wrote:
The changes in 8220493 (Prepare Socket/ServerSocket for alternative
platform SocketImpl) disallow a number of scenarios where it is not
possible for `ServerSocket::implAccept` to accept a new connection with
a given Socket.
Right, the original CSR has all
The changes in 8220493 (Prepare Socket/ServerSocket for alternative
platform SocketImpl) disallow a number of scenarios where it is not
possible for `ServerSocket::implAccept` to accept a new connection with
a given Socket. This change proposes to 1) update the specification to
clarify the expected
On 06/06/2019 12:07, Chris Hegarty wrote:
Prior to 8221481 (Reimplement the Legacy Socket API), these tests were
run with the plain socket impl. They should be run with both
system-default SocketImpls to ensure that the impls behave as expected.
Looks good.
+1 from me too.
Arthur,
This test is failing quite frequently in our build and test system. If not
pushed by this time tomorrow, I will push it on your behalf.
-Chris.
> On 6 Jun 2019, at 12:13, Daniel Fuchs wrote:
>
> Hi Arthur,
>
> Looks good to me too.
> I have run it through our test sys
Hi Arthur,
Looks good to me too.
I have run it through our test system and saw no issues.
best regards,
-- daniel
On 04/06/2019 11:27, Alan Bateman wrote:
On 03/06/2019 16:17, Arthur Eubanks wrote:
I don't think it's a big difference either way, but changed it to
System.out. Also ad
Prior to 8221481 (Reimplement the Legacy Socket API), these tests were
run with the plain socket impl. They should be run with both
system-default SocketImpls to ensure that the impls behave as expected.
$ hg diff
diff --git a/test/jdk/java/net/SocketOption/AfterClose.java
b/test/jdk/java/net/Soc
