RE: [RFR] 8194231: java/net/DatagramSocket/ReuseAddressTest.java failed with java.net.BindException: Address already in use: Cannot bind

2019-05-31 Thread Langer, Christoph
Thanks, Chris. I pushed it then on behalf of Arno. > -Original Message- > From: net-dev On Behalf Of Chris > Hegarty > Sent: Freitag, 31. Mai 2019 16:06 > To: Zeller, Arno > Cc: net-dev@openjdk.java.net > Subject: Re: [RFR] 8194231: > java/net/DatagramSocket/ReuseAddressTest.java failed

Re: [RFR] 8194231: java/net/DatagramSocket/ReuseAddressTest.java failed with java.net.BindException: Address already in use: Cannot bind

2019-05-31 Thread Chris Hegarty
> On 28 May 2019, at 16:20, Chris Hegarty wrote: > > .. > > I would like to run it through our internal build and test infra, after which > I’ll post the results here. All clear ( this test passes successfully in our build and test environment ). -Chris.

Re: RFR [13] 8225037: java.net.JarURLConnection::getJarEntry() throws NullPointerException

2019-05-31 Thread Vyom Tewari26
Hi Chris,   Change looks OK to me as method specifications tells " This  method returns null if the JAR file URL corresponding to this  connection points to a JAR file and not a JAR file entry."   Thanks, Vyom   - Original message -From: Chris Hegarty Sent by: "net-dev" To: OpenJDK Network

RFR [13] 8225037: java.net.JarURLConnection::getJarEntry() throws NullPointerException

2019-05-31 Thread Chris Hegarty
The implementation of java.net.JarURLConnection has a private String, `entryName`, that is used to hold the optional jar file entry name. If the JAR file URL corresponding to the JarURLConnection points to a JAR file and not a JAR file entry, then `entryName` will be `null` ( which should be ok ).