Re: [ipv6] Regarding 8220673: Add test library support for determining platform IP support

2019-05-06 Thread Martin Buchholz
On Thu, May 2, 2019 at 2:28 AM Daniel Fuchs wrote: > > 1. IPSupport needs to read system properties, attempts > to bind sockets etc... I wonder how that might interact > with tests that use a security manager, as some of these > operations may throw a SecurityException. > Maybe so

Re: RFR: JDK-8184770: JDWP support for IPv6

2019-05-06 Thread serguei.spit...@oracle.com
Hi Alex, It looks great and very solid in general! Some minor comments are below. http://cr.openjdk.java.net/~amenkov/IPv6/webrev.04/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c.frames.html 263 * Result must be release wit

Re: [ipv6] RFR: 8223214: Inet6AddressImpl.loopbackAddress() should choose loopback address that is available

2019-05-06 Thread Alan Bateman
On 06/05/2019 18:31, Arthur Eubanks wrote: I added a test that set an empty SecurityManager and called InetAddress.getLoopbackAddress(). It passed, there were no permission issues. Then I looked at the code around NetworkInterface.getByInetAddress(), and I don't see anything related to security