Hi Arthur,
On 26/03/2019 16:51, Arthur Eubanks wrote:
Changed B6890349.java to use URL constructor.
Changed sequence of URIBuilder calls to `.host().port().path()`.
Added missing `.path("/")`.
Added logging for most of the constructed URLs.
PTAL:
http://cr.openjdk.java.net/~aeubanks/8220575/w
Changed B6890349.java to use URL constructor.
Changed sequence of URIBuilder calls to `.host().port().path()`.
Added missing `.path("/")`.
Added logging for most of the constructed URLs.
PTAL:
http://cr.openjdk.java.net/~aeubanks/8220575/webrev.01/test/jdk/com/sun/net/httpserver/bugs/B6373555.java
Arthur,
I like the way this is turning out.
> On 26 Mar 2019, at 12:05, Daniel Fuchs wrote:
>
> ...
> 2. B6890349.java
>
> Using URI.toURL() in this test will change the nature of
> the test. I believe that in this specific case using the
> multi-arg URL constuctor should be preferred.
>
I've applied your patch and run through our test system. The
sun/net/www/protocol/http/B6890349.java
test failed just like you said. I'm happy to say that it was the only test in
the whole networking area that failed. So test-wise it looks good.
-Pavel
Hi Arthur,
I believe this looks good. Here are my comments so far:
I like the fact that you kept the builder implementation
very minimal, and focused on what these tests actually
need. We can always revisit that later if we come across
new tests that need more than what your proposed implementat
Thanks, Christoph!
On Tue, Mar 26, 2019, 9:41 AM Langer, Christoph
wrote:
> Hi Thomas,
>
>
>
> looks good 😊
>
>
>
> Christoph
>
>
>
> *From:* net-dev *On Behalf Of *Thomas
> Stüfe
> *Sent:* Montag, 25. März 2019 14:15
> *To:* net-dev
> *Subject:* RFR(xxxs): 8221406: Windows 32bit build error i
Hi Thomas,
looks good 😊
Christoph
From: net-dev On Behalf Of Thomas Stüfe
Sent: Montag, 25. März 2019 14:15
To: net-dev
Subject: RFR(xxxs): 8221406: Windows 32bit build error in
NetworkInterface_winXP.c
Hi all,
please review this tiny fix to a windows 32 build warning:
Issue: https://bugs
