Hi Ivan,
thanks for explanation, code change looks good to me.
Thanks,
Vyom
On Thu, Mar 21, 2019 at 11:26 AM Ivan Gerasimov
wrote:
> Thanks Vyom!
>
> On 3/20/19 10:13 PM, Vyom Tiwari wrote:
>
> Hi Ivan,
>
> Looks OK to me, in case of exception "ni" will be null you can use the
> macro(CHECK
Thanks Vyom!
On 3/20/19 10:13 PM, Vyom Tiwari wrote:
Hi Ivan,
Looks OK to me, in case of exception "ni" will be null you can use
the macro(CHECK_NULL_RETURN) if you are not clearing the JNI
exception, this will save at least one additional function(
"(*env)->ExceptionOccurred(env)" ) call
Hi Ivan,
Looks OK to me, in case of exception "ni" will be null you can use the
macro(CHECK_NULL_RETURN) if you are not clearing the JNI exception, this
will save at least one additional function( "(*env)->ExceptionOccurred(env)"
) call.
Thanks,
Vyom
On Wed, Mar 20, 2019 at 9:49 PM Ivan Geras
Hi Ivan,
looks good to me.
Best regards
Christoph
> -Original Message-
> From: net-dev On Behalf Of Ivan
> Gerasimov
> Sent: Mittwoch, 20. März 2019 17:18
> To: net-dev
> Subject: RFR 8170494 : JNI exception pending in PlainDatagramSocketImpl.c
>
> Hello!
>
> The function Java_java_n
I have a use case where I need to implement a custom SocketImpl class and I've
run into some difficulty caused by the current design of SocketImpl and the
related classes in OpenJDK. My use case is implementing a custom proxy
protocol, similar in spirit to what SocksSocketImpl does but using a
Hello!
The function Java_java_net_NetworkInterface_getByInetAddress0 may throw,
so after calling it we need to check if an exception is pending.
Would you please help review a one-line fix?
BUGURL: https://bugs.openjdk.java.net/browse/JDK-8170494
WEBREV: http://cr.openjdk.java.net/~igerasim/8
