Re: RFR: 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 for some tests

Updated copyright years (I asked around, it should be fine), updated commit message. http://cr.openjdk.java.net/~aeubanks/8220083/webrev.01 On Mon, Mar 11, 2019 at 10:46 AM Martin Buchholz wrote: > These changes are clean progress and allow tests to pass on any of the 4 > (!) combinations of IPV

Re: RFR: 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 for some tests

These changes are clean progress and allow tests to pass on any of the 4 (!) combinations of IPV4/IPV6 support available. LGTM. BUT ... in the current multi-protocol world it's probably better to test against all the interfaces available on the host machine. Maybe there should be a InetAddress.ge

Re: RFR: 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 for some tests

This looks good to me. - Michael. On 11/03/2019, 16:55, Arthur Eubanks wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8220083 webrev: http://cr.openjdk.java.net/~aeubanks/8220083/webrev.00/ First of a few ipv6 patches to come.

Re: RFR: 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 for some tests

Tested with $ make test TEST="test/jdk/com/sun/net/httpserver test/jdk/com/sun/nio/ test/jdk/java/net test/jdk/java/nio/channels test/jdk/java/rmi/transport/ test/jdk/jdk/net/ test/jdk/sun/net/" That's useful information, but unfortunately jcheck will reject it. Please edit the commit metadata

Re: RFR: 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 for some tests

On Mon, Mar 11, 2019 at 10:18 AM Daniel Fuchs wrote: > > Also please update the copyright years in the files you're > changing. > > Google policy is to leave Copyright years in source files untouched. Especially another company's!

Re: RFR: 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 for some tests

Hi Arthur, I believe this is generally good. The question I have is whether the URLs that use "127.0.0.1" should also be changed to to use whatever address is returned InetAddress.getLoopbackAddress(). If it is needed it may require a bit more coding to ensure that [ ] are correctly added if the

Re: RFR 8184315: Typo in java.net.JarURLConnection.getCertificates() method documentation

Looks good Chris. best regards, -- daniel On 11/03/2019 17:03, Chris Hegarty wrote: Trivial typo fixes to: 1) use the simple present tense of the verb, and 2) correctly pluralize the return value. Similar to that of JarEntry::getCertificates. --- a/src/java.base/share/classes/java/net/JarURLC

Re: RFR: 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 for some tests

Arthur, On 11/03/2019 16:55, Arthur Eubanks wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8220083 webrev: http://cr.openjdk.java.net/~aeubanks/8220083/webrev.00/ In principle, I think this is good. I want to run some tests with your patch, and do a detailed review. Will reply with resul

RFR 8184315: Typo in java.net.JarURLConnection.getCertificates() method documentation

Trivial typo fixes to: 1) use the simple present tense of the verb, and 2) correctly pluralize the return value. Similar to that of JarEntry::getCertificates. --- a/src/java.base/share/classes/java/net/JarURLConnection.java +++ b/src/java.base/share/classes/java/net/JarURLConnection.java @@ -279,

Re: Disable TLS 1.3 backward compatibility mode?

-bcc net-dev Copying security-dev as TLS 1.3 topics are more appropriate for that mailing list. --Sean On 3/10/19 3:24 PM, ra...@web.de wrote: Dear, the Java TLS 1.3 implementation supports middlebox compatibility (e.g. sends a non-empty session id and a ChangeCipherSpec message). Out of i