Re: RFR 8215008: Clear confusion between URL/URI paths and file system paths

2018-12-10 Thread Martin Buchholz
Thanks. Looks good. Tangentially ... I see URLClassLoader uses URLClassPath which uses FileURLMapper, which tries to directly convert a URL to a String path. FileURLMapper uses URL#getFile, and TIL that #getFile differs from #getPath in that it also returns a query component where present. Maybe

Re: RFR 8215008: Clear confusion between URL/URI paths and file system paths

2018-12-10 Thread Alan Bateman
On 10/12/2018 17:54, Daniel Fuchs wrote: Hi Alan, Here is an updated webrev that takes into account your later feedback: http://cr.openjdk.java.net/~dfuchs/webrev_8215008/webrev.02/ This update looks good to me. -Alan

Re: RFR 8215008: Clear confusion between URL/URI paths and file system paths

2018-12-10 Thread Daniel Fuchs
Hi Alan, Here is an updated webrev that takes into account your later feedback: http://cr.openjdk.java.net/~dfuchs/webrev_8215008/webrev.02/ best regards, -- daniel On 07/12/2018 16:16, Daniel Fuchs wrote: Thanks for the feedback Alan! I have updated the webrev accordingly: http://cr.openj