Re: RFR [12] 8211927: Add additional diagnostic information to java/net/BindException/Test.java

Hi Chris, If that works with jtreg, then looks good to me :-) best regards, -- daniel On 09/10/2018 14:10, Chris Hegarty wrote: This test has been failing intermittently for a long time. It is difficult to diagnose the cause of the failure, as the test output doesn’t provide much information.

RFR [12] 8211927: Add additional diagnostic information to java/net/BindException/Test.java

This test has been failing intermittently for a long time. It is difficult to diagnose the cause of the failure, as the test output doesn’t provide much information. Time to add some diagnostic output. --- a/test/jdk/java/net/BindException/Test.java +++ b/test/jdk/java/net/BindException/Test.java

Re: RFR [12] 8211902: broken link in java.net.http.WebSocket.Builder

> On 9 Oct 2018, at 12:37, Daniel Fuchs wrote: > > Hi Chris, > > Looks good but maybe you could fix "the the" at > the same time. Argh! yes, of course. I’ll fix this before pushing. -Chris.

Re: RFR [12] 8211902: broken link in java.net.http.WebSocket.Builder

Hi Chris, Looks good but maybe you could fix "the the" at the same time. On 09/10/2018 12:03, Chris Hegarty wrote:           *          in which the the listener is invoked. cheers, -- daniel

Re: RFR [12] 8211902: broken link in java.net.http.WebSocket.Builder

On 09/10/2018 12:03, Chris Hegarty wrote: Trivially, this link should refer to HttpClient, rather than HttpRequest. --- a/src/java.net.http/share/classes/java/net/http/WebSocket.java +++ b/src/java.net.http/share/classes/java/net/http/WebSocket.java @@ -197,7 +197,7 @@         * {@link Securi

RFR [12] 8211902: broken link in java.net.http.WebSocket.Builder

Trivially, this link should refer to HttpClient, rather than HttpRequest. --- a/src/java.net.http/share/classes/java/net/http/WebSocket.java +++ b/src/java.net.http/share/classes/java/net/http/WebSocket.java @@ -197,7 +197,7 @@ * {@link SecurityException} - * if a sec