Re: [12] RFR 8199931: java/net/MulticastSocket/UnreferencedMulticastSockets.java fails with "incorrect data received"

2018-09-20 Thread Chris Hegarty
Looks good. Thanks. -Chris > On 21 Sep 2018, at 02:51, Chris Yin wrote: > > Hi, Chris H > > Thanks for your suggestion, changed as below to just print client bound port > as you mentioned. Certainly, this is not a fix, just add some debug info, > hope we could get next failure sample to prov

[12] RFR 8169246: java/net/DatagramSocket/ReportSocketClosed.java fails intermittently with BindException

2018-09-20 Thread Chris Yin
Please review below minor change for 8169246, thanks The failure log indicate "BindException: Address already in use”, I didn’t see any reason for this test to use a fixed port 4001 that may occupied by others, so propose to just remove fixed port. bug: https://bugs.openjdk.java.net/browse/JDK-

RFR (12): 8210934: Move sun/net/www/protocol/http/GetErrorStream.java to OpenJDK

2018-09-20 Thread Frank Yuan
Hi all Would you like to review this patch? Bug: https://bugs.openjdk.java.net/browse/JDK-8210934 Webrev: http://cr.openjdk.java.net/~fyuan/8210934/webrev.01/ It is to move this test to open after getting rid of the internal network dependency. Thanks Frank

Re: [12] RFR 8199931: java/net/MulticastSocket/UnreferencedMulticastSockets.java fails with "incorrect data received"

2018-09-20 Thread Chris Yin
Hi, Chris H Thanks for your suggestion, changed as below to just print client bound port as you mentioned. Certainly, this is not a fix, just add some debug info, hope we could get next failure sample to prove the guess :) New Changes: diff -r c26fbf1434c4 test/jdk/java/net/MulticastSocket/Un

Re: [12] RFR 8199931: java/net/MulticastSocket/UnreferencedMulticastSockets.java fails with "incorrect data received"

2018-09-20 Thread Chris Hegarty
Thank you for looking at this issue Chris Y. I don’t disagree with the changes, but if you want to confirm your suspicion, that the same port is being reused, then printing out the client’s bound port would do that ( since the servers port is already printed in the logs ). If such a change was i

[12] RFR 8199931: java/net/MulticastSocket/UnreferencedMulticastSockets.java fails with "incorrect data received"

2018-09-20 Thread Chris Yin
Loop net-dev since the test is under java/net, thanks > On 20 Sep 2018, at 5:30 PM, Chris Yin wrote: > > Please review below minor change for 8199931, thanks > > A little explanation about the change here, since the failure samples are too > less (seems too hard to repro), so below scenario wh