Re: [openjdk-x] Bind to a multicast address fails

2018-09-13 Thread Andre Naujoks
On 9/10/18 10:36 AM, Andre Naujoks wrote: > On 9/8/18 11:49 AM, Andre Naujoks wrote: >> On 9/7/18 6:08 PM, David Lloyd wrote: >>> On Fri, Sep 7, 2018 at 6:56 AM Andre Naujoks wrote: On 9/7/18 1:15 PM, Alan Bateman wrote: > On 07/09/2018 10:49, Decke, Hendrik (K-GERFA/A) wrote: >>

Re: RFR: 8210311: IllegalArgumentException in CookieManager - Comparison method violates its general contract

2018-09-13 Thread Michael McMahon
Thanks for the reviews. This suggestion looks reasonable Daniel. Michael. On 13/09/2018, 10:00, Daniel Fuchs wrote: Looks good Michael! An alternative in HttpCookie.java would be to do: 144 private HttpCookie(String name, String value, String header) { - 145 this(name, value, he

Re: RFR: 8210311: IllegalArgumentException in CookieManager - Comparison method violates its general contract

2018-09-13 Thread Daniel Fuchs
Looks good Michael! An alternative in HttpCookie.java would be to do: 144 private HttpCookie(String name, String value, String header) { - 145 this(name, value, header, -1); + 145 this(name, value, header, System.currentTimeMillis()); 146 } [...] - 162 when

Re: RFR: 8210311: IllegalArgumentException in CookieManager - Comparison method violates its general contract

2018-09-13 Thread Chris Hegarty
> On 12 Sep 2018, at 17:28, Michael McMahon > wrote: > > Could I get the following reviewed please? > It fixes a problem in j.n.CookieManager where an internal Comparator was not > obeying its contract > and crashing occasionally in Collections.sort(). It also updates the behavior > (sorting