RFR: 8210311: IllegalArgumentException in CookieManager - Comparison method violates its general contract

2018-09-12 Thread Michael McMahon
Could I get the following reviewed please? It fixes a problem in j.n.CookieManager where an internal Comparator was not obeying its contract and crashing occasionally in Collections.sort(). It also updates the behavior (sorting of cookie headers) to RFC6265. http://cr.openjdk.java.net/~michael

Re: [openjdk-x] Bind to a multicast address fails

2018-09-12 Thread Chris Hegarty
Vyom, On 12/09/18 10:09, vyom tewari wrote: Hi Alan,Chris, I imported the Andre's patch and our all existing internal tests are clean. Ok, great. This is as expected. Next step would be to create a few tests to verify the change. Maybe look as some existing tests that use join, and refactor

Re: [openjdk-x] Bind to a multicast address fails

2018-09-12 Thread Alan Bateman
On 12/09/2018 10:09, vyom tewari wrote: Hi Alan,Chris, I imported the Andre's patch and our all existing internal tests are clean. Good to hear! Next step will be to add or extend existing tests to cover binding to both IPv4 and IPv6 multicast addresses. The Promiscuous tests (one for Mu

Re: [openjdk-x] Bind to a multicast address fails

2018-09-12 Thread vyom tewari
Hi Alan,Chris, I imported the Andre's patch and our all existing internal tests are clean. Thanks, Vyom On Monday 10 September 2018 10:58 PM, Chris Hegarty wrote: On 10/09/18 15:35, Chris Hegarty wrote: ... Maybe the native implementation of these methods can be updated to accept a scope,