RE: [PATCH] SOCK_CLOEXEC for opening sockets

2018-08-30 Thread Andrew Luo
Just checking to see if anyone has any other comments/feedback on this. Thanks, -Andrew -Original Message- From: Andrew Luo Sent: Monday, July 30, 2018 9:44 PM To: 'Andrew Luo' ; Ivan Gerasimov ; Chris Hegarty Cc: net-dev@openjdk.java.net Subject: RE: [PATCH] SOCK_CLOEXEC for opening

Re: RFR [XS]: 8210147: adjust some WSAGetLastError usages in windows network coding - was : RE: WSAGetLastError usage in jdk/src/java.base/windows/native/libnet/SocketInputStream.c

2018-08-30 Thread Chris Hegarty
Post-push Review ;-) I think this looks good. Thanks for catching and fix it Matthias. -Chris. > On 30 Aug 2018, at 09:02, Baesken, Matthias wrote: > > Thanks ! > >> -Original Message- >> From: Langer, Christoph >> Sent: Donnerstag, 30. August 2018 09:59 >> To: Baesken, Matthias ; ne

RE: RFR [XS]: 8210147: adjust some WSAGetLastError usages in windows network coding - was : RE: WSAGetLastError usage in jdk/src/java.base/windows/native/libnet/SocketInputStream.c

2018-08-30 Thread Baesken, Matthias
Thanks ! > -Original Message- > From: Langer, Christoph > Sent: Donnerstag, 30. August 2018 09:59 > To: Baesken, Matthias ; net-dev d...@openjdk.java.net> > Subject: RE: RFR [XS]: 8210147: adjust some WSAGetLastError usages in > windows network coding - was : RE: WSAGetLastError usage in

RE: RFR [XS]: 8210147: adjust some WSAGetLastError usages in windows network coding - was : RE: WSAGetLastError usage in jdk/src/java.base/windows/native/libnet/SocketInputStream.c

2018-08-30 Thread Langer, Christoph
Hi Matthias, > Can I have a second review please ? +1 Best regards Christoph