Thanks Thomas !
Can I have a second review please ?
Best regards, Matthias
> -Original Message-
> From: Thomas Stüfe
> Sent: Mittwoch, 29. August 2018 15:22
> To: Baesken, Matthias
> Cc: net-dev
> Subject: Re: RFR [XS]: 8210147: adjust some WSAGetLastError usages in
> windows network
Looks fine.
Regards, Thomas
On Wed, Aug 29, 2018 at 3:15 PM, Baesken, Matthias
wrote:
> Please review this change, it adjusts some usages of WSAGetLastError
> in windows net - coding.
>
> Change :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8210147/
>
> Bug :
>
> https://bugs.o
Please review this change, it adjusts some usages of WSAGetLastError in
windows net - coding.
Change :
http://cr.openjdk.java.net/~mbaesken/webrevs/8210147/
Bug :
https://bugs.openjdk.java.net/browse/JDK-8210147
Thanks , Matthias
> -Original Message-
> From: Thomas Stüf
Hi Matthias,
On Wed, Aug 29, 2018 at 9:46 AM, Baesken, Matthias
wrote:
>
>> What I would do to keep the change simple is just passing 0 or -1 as
>> errorNum argument to NET_ThrowNew - in that case it will say
>> "Unspecified socket error" in the exception. Just make sure that 0 or
>> -1, whatever
> What I would do to keep the change simple is just passing 0 or -1 as
> errorNum argument to NET_ThrowNew - in that case it will say
> "Unspecified socket error" in the exception. Just make sure that 0 or
> -1, whatever you use, is not one of the WSAx constants
Hi Thomas, according to
http
