Hi Matthias,
I neglected to mention that an appropriate noreg-* label [1], perhaps
“noreg-cleanup," will be needed on the issue as it seems likely untestable.
Thanks,
Brian
[1] http://openjdk.java.net/guide/changePlanning.html#bug, section 6.
On Aug 27, 2018, at 8:12 AM, Baesken, Matthias wr
Hi Matthias,
This looks fine to me.
Thanks,
Brian
On Aug 27, 2018, at 8:12 AM, Baesken, Matthias wrote:
> Hello, please review this small fix ;
>
> When returning from Java_java_net_NetworkInterface_getAll (windows
> version), we have to free resources to avoid leaks.
> In some speci
Hi Matthias,
the change looks good but I think you should also initialize 'ifList'
in 'Java_java_net_NetworkInterface_getAll()' with NULL otherwise its
value is undefined and if 'enumInterfaces()' returns with an error
without assigning 'ifList' you may end up calling 'free_netif()' with
an undefi
On 27 Aug 2018, at 16:12, Baesken, Matthias wrote:
>
> ...
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8209994/
Looks good. Thanks.
-Chris.
Hello, please review this small fix ;
When returning from Java_java_net_NetworkInterface_getAll (windows version),
we have to free resources to avoid leaks.
In some special cases this is not done .
Bug :
https://bugs.openjdk.java.net/browse/JDK-8209994
change :
http://cr.openjdk.java.
