Re: [PATCH] SOCK_CLOEXEC for opening sockets

> On 19 Jul 2018, at 18:41, Andrew Luo > wrote: > > Just checking - is there any other changes that I should make to the patch, > or anything else you guys need me to do? A webrev genderated from Andrew’s patch along with: 1) some additional includes of “net_util_md.h” in several missing pl

Connection timeouts in JEP 321 (HTTP Client)

Somebody pointed me at the upcoming HTTP client implementation, and I'm sad to see that connection timeouts are missing from the implementation (the old HTTP API). Is the absence of connection timeouts intended or an oversight? I'd like to see it added, and it looks like a simple change to me. htt

Re: RFR : 8205959 : Do not restart close if errno is EINTR

According to http://man7.org/linux/man-pages/man2/close.2.html it is currently platform-dependent whether close() must or must not (seems to be no middle ground) be retried. Might have to do some #ifdef guarding? -- - DML > On Jun 27, 2018, at 6:15 PM, Ivan Gerasimov wrote: > > Hello! > >

Re: HttpURLConnection throws SunCertPathBuilderException in jdk11

This should be fixed in JDK 11 b23. Please try again. See https://bugs.openjdk.java.net/browse/JDK-8199779 for more info. --Sean On 6/25/18 12:28 AM, Jaikiran Pai wrote: I couldn't locate this bug in the JIRA nor the bugs.java.net, to see if it's acknowledged as an issue. So FWIW - I can repro

Re: RFR: 8172346 sun.net.ftp.FtpDirEntry.setCreated(Date) may expose internal represent

Hi Chris, Thanks for review, please find my comment inline. Thanks, Vyom On Tuesday 24 July 2018 06:54 PM, Chris Hegarty wrote: On 24 Jul 2018, at 10:55, vyom tewari wrote: Hi All, Please review below a trivial fix. Webrev : http://cr.openjdk.java.net/~vtewari/8172346/webrev0.0/index.htm

Re: RFR: 8172346 sun.net.ftp.FtpDirEntry.setCreated(Date) may expose internal represent

On 24 Jul 2018, at 10:55, vyom tewari wrote: > > Hi All, > > Please review below a trivial fix. > > Webrev : http://cr.openjdk.java.net/~vtewari/8172346/webrev0.0/index.html > > BugID: https://bugs.openjdk.java.net/browse/JDK-8172346 > > The above code change will avoid storing the externally

Re: RFR [11] 8207960: Non-negative WINDOW_UPDATE increments may leave the stream window size negative

Looks good Chris - Michael. On 24/07/2018, 10:23, Chris Hegarty wrote: The stream window size can correctly become negative after processing the initial SETTINGS_INITIAL_WINDOW_SIZE. Stream specific WINDOW_UPDATE's should not cause a stream reset if the current window size is negative before th

RFR: 8172346 sun.net.ftp.FtpDirEntry.setCreated(Date) may expose internal represent

Hi All, Please review below a trivial fix. Webrev : http://cr.openjdk.java.net/~vtewari/8172346/webrev0.0/index.html BugID: https://bugs.openjdk.java.net/browse/JDK-8172346 The above code change will avoid storing the externally mutable object reference into FtpDirEntry. Thanks, Vyom

RFR [11] 8207960: Non-negative WINDOW_UPDATE increments may leave the stream window size negative

The stream window size can correctly become negative after processing the initial SETTINGS_INITIAL_WINDOW_SIZE. Stream specific WINDOW_UPDATE's should not cause a stream reset if the current window size is negative before the positive increment amount is added. http://cr.openjdk.java.net/~chegar/

Re: RFR [11 8207959 The initial value of SETTINGS_MAX_CONCURRENT_STREAMS should have no limit

This looks fine, Chris. - Michael. On 23/07/2018, 11:43, Chris Hegarty wrote: The initial value for the directional parameter SETTINGS_MAX_CONCURRENT_STREAMS, in the direction from the server to the client, max concurrent client-initiated streams, is incorrectly limited to 100, when there shoul