Re: RFR : 8205959 : Do not restart close if errno is EINTR

2018-06-28 Thread Alan Bateman
On 28/06/2018 17:35, David Lloyd wrote: : Do you (or Alan) think that this might have accounted for real-world connection problems? In the file I/O area, with NFS I think, we had an issue a long time ago where close was retried after EIO. That issue was fixed a long time ago but it's one that

Re: RFR : 8205959 : Do not restart close if errno is EINTR

2018-06-28 Thread David Lloyd
On Wed, Jun 27, 2018 at 6:52 PM Ivan Gerasimov wrote: > Here I'm patching only the Linux-specific file > src/java.base/linux/native/libnet/linux_close.c > So no #ifdefs seem necessary. > > MacOS variant also uses the same pattern, but I'm not touching it exactly > because the behavior not quite

Re: RFR : 8205959 : Do not restart close if errno is EINTR

2018-06-28 Thread Alan Bateman
On 28/06/2018 00:15, Ivan Gerasimov wrote: Hello! When closing a socket via NET_SocketClose(int fd), a close(fd) is called. The later is wrapped in a retry-loop, which is wrong because close() is not restartable. The `man 2 close` states: """ ... close() should not be retried after an EINTR s